Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not commit examples spec files #4860

Closed
bahmutov opened this issue Jul 29, 2019 · 3 comments · Fixed by #4862
Closed

Do not commit examples spec files #4860

bahmutov opened this issue Jul 29, 2019 · 3 comments · Fixed by #4862
Assignees
Labels
process: build Related to our internal build process

Comments

@bahmutov
Copy link
Contributor

When we bundle cypress-example-kitchensink example specs, we copy them and commit to the repo. This leads to the duplication and makes updating cypress-example-kitchensink version hard (have to remember to run npm run build!)

Instead we should just "build" the example when building the test runner binary and not commit these files

@bahmutov bahmutov self-assigned this Jul 29, 2019
@bahmutov bahmutov added the process: build Related to our internal build process label Jul 29, 2019
@brian-mann
Copy link
Member

I believe we just need to add packages/example/cypress to .gitignore and delete the existing files.

The binary building process already runs the appropriate npm run build steps to ensure that the latest files are copied over from the kitchensink.

@cypress-bot
Copy link
Contributor

cypress-bot bot commented Jul 29, 2019

The code for this is done in cypress-io/cypress#4862, but has yet to be released.
We'll update this issue and reference the changelog when it's released.

@cypress-bot
Copy link
Contributor

cypress-bot bot commented Jul 29, 2019

Released in 3.4.1.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
process: build Related to our internal build process
Projects
None yet
2 participants