Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cypress click coordinates incorrect when element inside Iframe #4347

Closed
kuceb opened this issue May 30, 2019 · 2 comments · Fixed by #3030
Closed

Cypress click coordinates incorrect when element inside Iframe #4347

kuceb opened this issue May 30, 2019 · 2 comments · Fixed by #3030
Labels
topic: cy.click 🖱 topic: iframes type: bug

Comments

@kuceb
Copy link
Contributor

kuceb commented May 30, 2019

Cypress calculates coords for the click assuming the element is in the topmost frame, which causes coords to be off:

I clicked the hashchange, which was at the top of an iframe:
image

So Cypress thought I clicked the top of my AUT frame:
image

this will be fixed in #3030
@kuceb kuceb mentioned this issue May 30, 2019
Merged
28 tasks
@cypress-bot cypress-bot bot added the stage: ready for work The issue is reproducible and in scope label Jun 3, 2019
@cypress-bot cypress-bot bot added stage: needs review The PR code is done & tested, needs review stage: work in progress and removed stage: ready for work The issue is reproducible and in scope stage: needs review The PR code is done & tested, needs review labels Aug 8, 2019
@cypress-bot cypress-bot bot added stage: needs review The PR code is done & tested, needs review and removed stage: work in progress labels Sep 6, 2019
@cypress-bot cypress-bot bot added stage: work in progress stage: needs review The PR code is done & tested, needs review and removed stage: needs review The PR code is done & tested, needs review stage: work in progress labels Sep 25, 2019
@cypress-bot cypress-bot bot added stage: needs review The PR code is done & tested, needs review and removed stage: work in progress labels Oct 7, 2019
@cypress-bot cypress-bot bot added stage: pending release and removed stage: needs review The PR code is done & tested, needs review labels Oct 11, 2019
@cypress-bot
Copy link
Contributor

cypress-bot bot commented Oct 11, 2019

The code for this is done in cypress-io/cypress#3030, but has yet to be released.
We'll update this issue and reference the changelog when it's released.

@cypress-bot
Copy link
Contributor

cypress-bot bot commented Oct 23, 2019

Released in 3.5.0.

@snyk-bot snyk-bot mentioned this issue Nov 1, 2019
Merged
@snyk-bot snyk-bot mentioned this issue Nov 9, 2019
Closed
@cypress-io cypress-io locked as resolved and limited conversation to collaborators Jan 3, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
topic: cy.click 🖱 topic: iframes type: bug
Projects
None yet
Milestone
No milestone
2 participants
@jennifer-shehane @kuceb