-
Notifications
You must be signed in to change notification settings - Fork 3.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Protocol: [Performance] Add a progress indicator for uploads #28239
Comments
In considering what would benefit noninteractive shells, like in CI, while also allowing for effective masking for the console output in our system test snapshots, the formatting for the upload report will likely have to change dramatically. Currently, we print a list of artifacts that were uploaded, along with their filesize and with #28226, the duration of the upload. I'm proposing the following output formatting:
In cases of failure:
These dots would service as an activity indicator, rather than a full progress indicator. An ASCII spinning indicator would not work, due to noninteractive shell use. |
Maybe clean it up a bit.
|
Uploads currently happen in parallel rather than serial - we could display in that way, but it would necessitate making the uploads serial instead. |
@cacieprins What would be the implications of printing all of the upload results once all of the artifacts are done? Is that possible to do? Or way more complicated?
|
Completely possible, and actually a little easier. We'd just need the activity indicator between the (Uploading) and (Uploaded) message blocks, to accommodate noninteractive terminals |
Oh right. What is the intention of listing all the stuff we're uploading before it's uploaded? I guess there could be failures somewhere? Seems like we're listing info twice...for what benefit? |
Breaking it up
|
If protocol uploads take a long time for files, this could cause CI systems to time out. A possible solution to this would be to provide an iterative update to standard out (e.g. dots or something) that at least indicate that progress is being made and triggering CI not to time out
The text was updated successfully, but these errors were encountered: