Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cypress no longer needs X-Cypress-Is-XHR-Or-Fetch to determine resourceType #26622

Closed
AtofStryker opened this issue Apr 28, 2023 · 1 comment · Fixed by #26623
Closed

Cypress no longer needs X-Cypress-Is-XHR-Or-Fetch to determine resourceType #26622

AtofStryker opened this issue Apr 28, 2023 · 1 comment · Fixed by #26623
Assignees
@AtofStryker
Labels
browser: chrome browser: electron browser: firefox

Comments

@AtofStryker
Copy link
Contributor

What would you like?

The X-Cypress-Is-XHR-Or-Fetch header code in firefox, electron, and chromium based browsers can be removed as we can infer the resourceType from the browser prerequest.

Why is this needed?

Reduces overhead and unnecessary calculation that might be leading to performance issues.

Other

No response
@AtofStryker AtofStryker self-assigned this Apr 28, 2023
@AtofStryker AtofStryker mentioned this issue Apr 28, 2023
Merged
3 tasks
@cypress-bot
Copy link
Contributor

cypress-bot bot commented Aug 1, 2023

Released in 12.17.3.

This comment thread has been locked. If you are still experiencing this issue after upgrading to
Cypress v12.17.3, please open a new issue.

@cypress-bot cypress-bot bot locked as resolved and limited conversation to collaborators Aug 1, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@AtofStryker AtofStryker

Labels
browser: chrome browser: electron browser: firefox
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: reduce requests paused and redundant headers cypress-io/cypress
1 participant
@AtofStryker