Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Debug Page - Fix styling of Empty States #26041

Closed
warrensplayer opened this issue Mar 7, 2023 · 2 comments · Fixed by #26129
Closed

Debug Page - Fix styling of Empty States #26041

warrensplayer opened this issue Mar 7, 2023 · 2 comments · Fixed by #26129
Assignees

Comments

@warrensplayer
Copy link
Contributor

Current behavior

The Debug page empty state components do not render like the most recent designs. Currently, the DebugEmptyView component is using a percentage left and right margin for controlling the wrapping of the copy. This can result in the copy being too narrow when the browser width is smaller. Also, the copy in the link to the Cypress documentation for each empty state duplicates the content of the copy and is too verbose.

image.png

Desired behavior

Update the DebugEmptyView to use a max width of 640px instead of a percentage margin.

Update the copy for the links for each empty state to just say "Learn more". Give the "Learn more" links 8px of left margin to separate them a bit from the rest of the copy. Slack discussion

image.png
Note: This screenshot is from Figma and intended to show the different in max width for the copy and the "Learn more" link. Other elements do not necessarily match existing state

Figma - https://www.figma.com/file/PAOozuCxtfetqP8fUVvg0y/branch/QkCp2F69X0qyLo7qnYQ67e/Cypress-App?node-id=21167%3A199979&t=pTybv9JZ0VNMYnb4-1

@warrensplayer
Copy link
Contributor Author

@cypress-bot
Copy link
Contributor

cypress-bot bot commented Mar 28, 2023

Released in 12.9.0.

This comment thread has been locked. If you are still experiencing this issue after upgrading to
Cypress v12.9.0, please open a new issue.

@cypress-bot cypress-bot bot locked as resolved and limited conversation to collaborators Mar 28, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants