fix: scaffold correct config file #19776
Conversation
|
Thanks for taking the time to open a PR!
|
| break | ||
|
|
||
| default: | ||
| throw new Error('Unreachable') |
There was a problem hiding this comment.
What does this error mean if we were to hit it?
There was a problem hiding this comment.
we should not hit it, but updated it to be safe cfd16b6
|
Test summary
Run details
View run in Cypress Dashboard ➡️ Flakiness
This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Dashboard |
||||||||||||||||||||||||||||||||||||||||||
…jandro/fix/scaffold-correct-config-file
…om:cypress-io/cypress into alejandro/fix/scaffold-correct-config-file
|
It looks like in WizardActions the comment is not indented properly. Would be worth fixing while we're at it: codeBlocks.push(`// Component testing, ${chosenLanguage.name}, ${chosenFramework.name}, ${chosenBundler.name}`) |
|
A few of my comments still stand, but other than that, seems fine |
|
@lmiller1990 This requires a more complex change - we are going to change the supportFile to be glob pattern so, it can detect by default |
User facing changelog
Additional details
How has the user experience changed?
PR Tasks
cypress-documentation?type definitions?cypress.schema.json?