Skip to content

Commit f73810d

Browse files
authored
test: make content consistent in component tests that use faker (#23080)
1 parent 40e1b36 commit f73810d

File tree

8 files changed

+20
-4
lines changed

8 files changed

+20
-4
lines changed

packages/app/src/components/FileMatchButton.cy.tsx

+2
Original file line numberDiff line numberDiff line change
@@ -6,6 +6,8 @@ import faker from 'faker'
66
import { ref } from 'vue'
77
const fileMatchButtonSelector = '[data-cy=file-match-button]'
88

9+
faker.seed(1)
10+
911
describe('<FileMatchButton />', () => {
1012
it('renders a small extension', () => {
1113
cy.mount(() => (<div class="p-12">

packages/app/src/components/FileMatchIndicator.cy.tsx

+2
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,8 @@
11
import FileMatchIndicator from './FileMatchIndicator.vue'
22
import faker from 'faker'
33

4+
faker.seed(1)
5+
46
describe('<FileMatchIndicator />', () => {
57
it('renders a reasonable length text', () => {
68
cy.mount(() => (<div class="p-12">

packages/frontend-shared/src/components/Alert.cy.tsx

+2
Original file line numberDiff line numberDiff line change
@@ -16,6 +16,8 @@ const prefixIconSelector = '[data-cy=alert-prefix-icon]'
1616

1717
const dismissSelector = `[aria-label=${messages.dismissAriaLabel}]`
1818

19+
faker.seed(1)
20+
1921
const alertTitle = faker.hacker.phrase()
2022
const alertBodyContent = faker.lorem.sentences(2)
2123

packages/frontend-shared/src/components/Collapsible.cy.tsx

+4-2
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,8 @@
11
import Collapsible from './Collapsible.vue'
22
import faker from 'faker'
33

4+
faker.seed(1)
5+
46
const targetText = 'Target'
57
const contentText = 'Content'
68
const targetSelector = '[data-testid=target]'
@@ -135,11 +137,11 @@ describe('<Collapsible />', { viewportHeight: 450, viewportWidth: 350 }, () => {
135137

136138
const target = ({ open }) => (<h1 class={['text-xl', { 'pb-2': open }]}>Click here to open</h1>)
137139

138-
cy.mount(() => (<div class="mx-auto text-center w-300px my-4 border-1 p-4 rounded">
140+
cy.mount(() => (<div class="rounded mx-auto border-1 my-4 text-center p-4 w-300px">
139141

140142
<Collapsible v-slots={{ target }}>
141143
<div class="space-y-2">
142-
<h2 class="text-center text-lg bg-gray-50">
144+
<h2 class="bg-gray-50 text-center text-lg">
143145
Content Header
144146
</h2>
145147
<p class="bg-red-500 h-900px">{ text }</p>

packages/frontend-shared/src/components/ListRowHeader.cy.tsx

+4-2
Original file line numberDiff line numberDiff line change
@@ -2,6 +2,8 @@ import ListRowHeader from './ListRowHeader.vue'
22
import faker from 'faker'
33
import FileChangesAdded from '~icons/cy/file-changes-added_x24.svg'
44

5+
faker.seed(1)
6+
57
const description = faker.hacker.phrase()
68
const header = faker.system.directoryPath()
79
const iconSelector = '[data-testid=file-added-icon]'
@@ -11,7 +13,7 @@ const descriptionSelector = '[data-testid=list-row-description]'
1113
describe('<ListRowHeader />', () => {
1214
it('renders the icon slot', () => {
1315
cy.mount(() => (
14-
<div class="p-4 text-center">
16+
<div class="text-center p-4">
1517
<ListRowHeader
1618
// @ts-ignore - doesn't know about vSlots
1719
vSlots={{
@@ -29,7 +31,7 @@ describe('<ListRowHeader />', () => {
2931

3032
it('renders a minimal example with an icon and description', () => {
3133
cy.mount(() => (
32-
<div class="p-4 text-center" data-testid="list-row-header">
34+
<div class="text-center p-4" data-testid="list-row-header">
3335
<ListRowHeader
3436
icon={() => <FileChangesAdded data-testid="file-added-icon"/>}
3537
description={description}

packages/frontend-shared/src/warning/Warning.cy.tsx

+2
Original file line numberDiff line numberDiff line change
@@ -3,6 +3,8 @@ import Warning from './Warning.vue'
33
import faker from 'faker'
44
import { ref } from 'vue'
55

6+
faker.seed(1)
7+
68
const title = faker.hacker.noun()
79
const message = `
810
# Hello!

packages/launchpad/src/components/code/FileRow.cy.tsx

+2
Original file line numberDiff line numberDiff line change
@@ -15,6 +15,8 @@ export default defineConfig({
1515
},
1616
})`
1717

18+
faker.seed(1)
19+
1820
const description = faker.hacker.phrase()
1921
const messages = defaultMessages.setupPage.configFile
2022

packages/launchpad/src/warning/WarningList.cy.tsx

+2
Original file line numberDiff line numberDiff line change
@@ -4,6 +4,8 @@ import faker from 'faker'
44
import { defaultMessages } from '@cy/i18n'
55
import { WarningList_RemoveWarningDocument } from '../generated/graphql'
66

7+
faker.seed(1)
8+
79
const warningSelector = '[data-cy=warning-alert]'
810

911
const createWarning = (props = {}) => ({

0 commit comments

Comments
 (0)