Merge branch 'develop' into astone123/schematic-support-file

Author: astone123

.circleci/workflows.yml

@@ -28,7 +28,7 @@ mainBuildFilters: &mainBuildFilters
       only:
         - develop
         - /^release\/\d+\.\d+\.\d+$/
-        - 'macOS-launch-arm-browser'
+        - 'mschile/chrome_memory_fix'
 
 # usually we don't build Mac app - it takes a long time
 # but sometimes we want to really confirm we are doing the right thing
@@ -37,15 +37,16 @@ macWorkflowFilters: &darwin-workflow-filters
   when:
     or:
     - equal: [ develop, << pipeline.git.branch >> ]
-    - equal: [ 'macOS-launch-arm-browser', << pipeline.git.branch >> ]
+    - equal: [ 'mschile/chrome_memory_fix', << pipeline.git.branch >> ]
     - matches:
         pattern: /^release\/\d+\.\d+\.\d+$/
         value: << pipeline.git.branch >>
+
 linuxArm64WorkflowFilters: &linux-arm64-workflow-filters
   when:
     or:
     - equal: [ develop, << pipeline.git.branch >> ]
-    - equal: [ 'macOS-launch-arm-browser', << pipeline.git.branch >> ]
+    - equal: [ 'mschile/chrome_memory_fix', << pipeline.git.branch >> ]
     - matches:
         pattern: /^release\/\d+\.\d+\.\d+$/
         value: << pipeline.git.branch >>
@@ -63,7 +64,7 @@ windowsWorkflowFilters: &windows-workflow-filters
   when:
     or:
     - equal: [ develop, << pipeline.git.branch >> ]
-    - equal: [ 'retry-flake', << pipeline.git.branch >> ]
+    - equal: [ 'mschile/chrome_memory_fix', << pipeline.git.branch >> ]
     - matches:
         pattern: /^release\/\d+\.\d+\.\d+$/
         value: << pipeline.git.branch >>
@@ -92,7 +93,7 @@ executors:
   mac:
     macos:
       # Executor should have Node >= required version
-      xcode: "14.0.0"
+      xcode: "14.0.1"
     resource_class: macos.x86.medium.gen2
     environment:
       PLATFORM: darwin
@@ -129,7 +130,7 @@ commands:
       - run:
           name: Check current branch to persist artifacts
           command: |
-            if [[ "$CIRCLE_BRANCH" != "develop" && "$CIRCLE_BRANCH" != "release/"* && "$CIRCLE_BRANCH" != "macOS-launch-arm-browser" ]]; then
+            if [[ "$CIRCLE_BRANCH" != "develop" && "$CIRCLE_BRANCH" != "release/"* && "$CIRCLE_BRANCH" != "mschile/chrome_memory_fix" ]]; then
               echo "Not uploading artifacts or posting install comment for this branch."
               circleci-agent step halt
             fi
@@ -1357,6 +1358,40 @@ jobs:
           path: /tmp/cypress
       - store-npm-logs
 
+  driver-integration-memory-tests:
+    <<: *defaults
+    parameters:
+      <<: *defaultsParameters
+      resource_class:
+        type: string
+        default: medium
+    resource_class: << parameters.resource_class >>
+    parallelism: 1
+    steps:
+      - restore_cached_workspace
+      - run:
+          name: Driver memory tests in Electron
+          environment:
+            CYPRESS_CONFIG_ENV: production
+          command: |
+            echo Current working directory is $PWD
+            node --version
+            if [[ `node ../../scripts/get-platform-key.js` == 'linux-arm64' ]]; then
+              # these are missing on Circle and there is no way to pre-install them on Arm
+              sudo apt-get update
+              sudo apt-get install -y libgbm-dev
+            fi
+
+            CYPRESS_INTERNAL_MEMORY_SAVE_STATS=true \
+            DEBUG=cypress*memory \
+            yarn cypress:run --browser electron --spec "cypress/e2e/memory/*.cy.*"
+          working_directory: packages/driver
+      - store_test_results:
+          path: /tmp/cypress
+      - store-npm-logs
+      - store_artifacts:
+          path: packages/driver/cypress/logs/memory
+
   unit-tests:
     <<: *defaults
     parameters:
@@ -1397,14 +1432,17 @@ jobs:
           path: packages/errors/__snapshot-images__
       - store-npm-logs
 
-  unit-tests-release:
+  verify-release-readiness:
     <<: *defaults
     resource_class: small
     parallelism: 1
+    environment:
+      GITHUB_TOKEN: $GH_TOKEN
     steps:
       - restore_cached_workspace
       - update_known_hosts
       - run: yarn test-npm-package-release-script
+      - run: node ./scripts/semantic-commits/validate-binary-changelog.js
 
   lint-types:
     <<: *defaults
@@ -1740,31 +1778,6 @@ jobs:
       - run:
           name: Build
           command: yarn workspace @cypress/webpack-preprocessor build
-      - run:
-          name: Test babelrc
-          command: yarn test
-          working_directory: npm/webpack-preprocessor/examples/use-babelrc
-      - run:
-          name: Build ts-loader
-          command: yarn install
-          working_directory: npm/webpack-preprocessor/examples/use-ts-loader
-      - run:
-          name: Types ts-loader
-          command: yarn types
-          working_directory: npm/webpack-preprocessor/examples/use-ts-loader
-      - run:
-          name: Test ts-loader
-          command: yarn test
-          working_directory: npm/webpack-preprocessor/examples/use-ts-loader
-      - run:
-          name: Start React app
-          command: yarn start
-          background: true
-          working_directory: npm/webpack-preprocessor/examples/react-app
-      - run:
-          name: Test React app
-          command: yarn test
-          working_directory: npm/webpack-preprocessor/examples/react-app
       - run:
           name: Run tests
           command: yarn workspace @cypress/webpack-preprocessor test
@@ -2364,7 +2377,7 @@ linux-x64-workflow: &linux-x64-workflow
     - unit-tests:
         requires:
           - build
-    - unit-tests-release:
+    - verify-release-readiness:
         context: test-runner:npm-release
         requires:
           - build
@@ -2422,6 +2435,9 @@ linux-x64-workflow: &linux-x64-workflow
         context: test-runner:cypress-record-key
         requires:
           - build
+    - driver-integration-memory-tests:
+        requires:
+          - build
     - run-frontend-shared-component-tests-chrome:
         context: [test-runner:cypress-record-key, test-runner:launchpad-tests, test-runner:percy]
         percy: true
@@ -2535,7 +2551,7 @@ linux-x64-workflow: &linux-x64-workflow
           - server-unit-tests
           - test-kitchensink
           - unit-tests
-          - unit-tests-release
+          - verify-release-readiness
           - cli-visual-tests
           - reporter-integration-tests
           - run-app-component-tests-chrome
@@ -2548,6 +2564,12 @@ linux-x64-workflow: &linux-x64-workflow
           - run-vite-dev-server-integration-tests
           - v8-integration-tests
 
+    - create-build-artifacts:
+        context:
+          - test-runner:upload
+          - test-runner:commit-status-checks
+        requires:
+          - build
     # various testing scenarios, like building full binary
     # and testing it on a real project
     - test-against-staging:
@@ -2563,12 +2585,6 @@ linux-x64-workflow: &linux-x64-workflow
         <<: *mainBuildFilters
         requires:
           - build
-    - create-build-artifacts:
-        context:
-          - test-runner:upload
-          - test-runner:commit-status-checks
-        requires:
-          - build
     - test-npm-module-on-minimum-node-version:
         requires:
           - create-build-artifacts
@@ -2663,6 +2679,12 @@ linux-arm64-workflow: &linux-arm64-workflow
         resource_class: arm.medium
         requires:
           - linux-arm64-build
+    - driver-integration-memory-tests:
+        name: linux-arm64-driver-integration-memory-tests
+        executor: linux-arm64
+        resource_class: arm.medium
+        requires:
+          - linux-arm64-build
 
 darwin-x64-workflow: &darwin-x64-workflow
   jobs:
@@ -2703,6 +2725,12 @@ darwin-x64-workflow: &darwin-x64-workflow
         resource_class: macos.x86.medium.gen2
         requires:
           - darwin-x64-build
+    - driver-integration-memory-tests:
+        name: darwin-x64-driver-integration-memory-tests
+        executor: mac
+        resource_class: macos.x86.medium.gen2
+        requires:
+          - darwin-x64-build
 
 darwin-arm64-workflow: &darwin-arm64-workflow
   jobs:
@@ -2736,6 +2764,12 @@ darwin-arm64-workflow: &darwin-arm64-workflow
         resource_class: cypress-io/latest_m1
         requires:
           - darwin-arm64-build
+    - driver-integration-memory-tests:
+        name: darwin-arm64-driver-integration-memory-tests
+        executor: darwin-arm64
+        resource_class: cypress-io/latest_m1
+        requires:
+          - darwin-arm64-build
 
 windows-workflow: &windows-workflow
   jobs:
@@ -2798,6 +2832,12 @@ windows-workflow: &windows-workflow
         resource_class: windows.large
         requires:
           - windows-build
+    - driver-integration-memory-tests:
+        name: windows-driver-integration-memory-tests
+        executor: windows
+        resource_class: windows.large
+        requires:
+          - windows-build
 
 workflows:
   linux-x64:

.github/PULL_REQUEST_TEMPLATE.md

@@ -7,12 +7,6 @@
 
 - Closes <!-- link to the issue here, if there is one -->
 
-### User facing changelog
-<!-- 
-Explain the change(s) for every user to read in our changelog. Examples: https://on.cypress.io/changelog
-If the change is not user-facing, write "n/a".
--->
-
 ### Additional details
 <!-- Examples:
 - Why was this change necessary?

.github/workflows/semantic-pull-request.yml

@@ -9,13 +9,21 @@ on:
 
 jobs:
   main:
-    name: Lint Title
+    name: Semantic Pull Request
     runs-on: ubuntu-latest
     steps:
-      # use a fork of the GitHub action - we cannot pull in untrusted third party actions
-      # see https://github.com/cypress-io/cypress/pull/20091#discussion_r801799647
-      - uses: cypress-io/action-semantic-pull-request@v4
-        env:
-          GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
+      - name: Checkout
+        uses: actions/checkout@v3
         with:
-          validateSingleCommit: true
+          ref: ${{ github.event.pull_request.head.ref }}
+          repository: ${{ github.event.pull_request.head.repo.full_name }}
+      - run: npm install
+        working-directory: scripts/github-actions/semantic-pull-request/
+      - name: Lint PR Title and Cypress Changelog Entry
+        if: github.event_name == 'pull_request_target'
+        uses: actions/github-script@v4
+        with:
+          script: |
+            const verifyPullRequest = require('./scripts/github-actions/semantic-pull-request')
+
+            await verifyPullRequest({ context, core, github })

.releaserc.base.js

@@ -1,3 +1,31 @@
+const { parserOpts, releaseRules } = require('./scripts/semantic-commits/change-categories')
+
 module.exports = {
-  ...require('./.releaserc.base'),
+  plugins: [
+    ['@semantic-release/commit-analyzer', {
+      preset: 'angular',
+      parserOpts,
+      releaseRules,
+    }],
+    ['@semantic-release/release-notes-generator',
+      {
+        preset: 'angular',
+        parserOpts,
+      }
+    ],
+    ['@semantic-release/changelog', {
+      changelogFile: 'CHANGELOG.md',
+    }],
+    ['@semantic-release/git', {
+      assets: [
+        './CHANGELOG.md',
+      ],
+      message: 'chore: release ${nextRelease.gitTag}\n\n[skip ci]',
+    }],
+    '@semantic-release/npm',
+  ],
+  extends: 'semantic-release-monorepo',
+  branches: [
+    { name: 'develop', channel: 'latest' },
+  ],
 }

.releaserc.js

@@ -14,10 +14,13 @@
         "Fetchables",
         "forcedefault",
         "getenv",
+        "GIBIBYTES",
         "graphcache",
         "headlessui",
         "Iconify",
         "intlify",
+        "KIBIBYTE",
+        "kibibytes",
         "Lachlan",
         "loggedin",
         "mksnapshot",
@@ -27,6 +30,7 @@
         "OVERLIMIT",
         "overscan",
         "packherd",
+        "pidusage",
         "Pinia",
         "pnpm",
         "pseudoclass",
@@ -41,6 +45,7 @@
         "snapshotting",
         "sourcemaps",
         "speclist",
+        "systeminformation",
         "testid",
         "TIMEDOUT",
         "titleize",