fix: filtering with --spec option for projects in Docker container root (#23535)

* fix: updating globbing patterns to work when mounted to the root directory

* Adding unit tests for globby calls

* Updating a few tests. Reordering for cleaner diff.

* Refactoring after develop merge

* Persist binary for validation

* Using arch-specific path sep

Author: tbiethman

circle.yml

@@ -132,7 +132,7 @@ commands:
       - run:
           name: Check current branch to persist artifacts
           command: |
-            if [[ "$CIRCLE_BRANCH" != "develop" && "$CIRCLE_BRANCH" != "tbiethman/22272-globbing-working-dir" ]]; then
+            if [[ "$CIRCLE_BRANCH" != "develop" && "$CIRCLE_BRANCH" != "tbiethman/23380-root-spec-pattern" ]]; then
               echo "Not uploading artifacts or posting install comment for this branch."
               circleci-agent step halt
             fi

packages/data-context/src/sources/FileDataSource.ts

@@ -9,6 +9,10 @@ import { toPosix } from '../util/file'
 
 const debug = Debug('cypress:data-context:sources:FileDataSource')
 
+export const matchGlobs = async (globs: string | string[], globbyOptions?: GlobbyOptions) => {
+  return await globby(globs, globbyOptions)
+}
+
 export class FileDataSource {
   constructor (private ctx: DataContext) {}
 
@@ -32,12 +36,14 @@ export class FileDataSource {
 
   async getFilesByGlob (cwd: string, glob: string | string[], globOptions?: GlobbyOptions) {
     const globs = ([] as string[]).concat(glob).map((globPattern) => {
+      const workingDirectoryPrefix = path.join(cwd, path.sep)
+
       // If the pattern includes the working directory, we strip it from the pattern.
       // The working directory path may include characters that conflict with glob
       // syntax (brackets, parentheses, etc.) and cause our searches to inadvertently fail.
       // We scope our search to the working directory using the `cwd` globby option.
-      if (globPattern.startsWith(cwd)) {
-        return globPattern.replace(cwd, '.')
+      if (globPattern.startsWith(workingDirectoryPrefix)) {
+        return globPattern.replace(workingDirectoryPrefix, '')
       }
 
       return globPattern
@@ -62,7 +68,7 @@ export class FileDataSource {
       debug('globbing pattern(s): %o', globs)
       debug('within directory: %s', cwd)
 
-      const files = await globby(globs, { onlyFiles: true, absolute: true, cwd, ...globOptions, ignore: ignoreGlob })
+      const files = await matchGlobs(globs, { onlyFiles: true, absolute: true, cwd, ...globOptions, ignore: ignoreGlob })
 
       return files
     } catch (e) {