Skip to content

Commit b0218e5

Browse files
AtofStrykerAtofStryker
committed
Squashed commit of the following:
commit bcba5ed Author: AtofStryker <bglesias@gmail.com> Date: Mon Sep 16 10:48:55 2024 -0400 fix: fix checkbox click events for firefox 129 and up [run ci] commit 8eb40d0 Author: AtofStryker <bglesias@gmail.com> Date: Wed Sep 11 10:18:00 2024 -0400 update docker image to chrome 128 and firefox 130 [run ci] commit 095b3da Author: Mike McCready <66998419+MikeMcC399@users.noreply.github.com> Date: Mon Sep 16 14:26:26 2024 +0200 chore: re-sync yarn.lock (#30237) commit f9810d1 Author: Jennifer Shehane <jennifer@cypress.io> Date: Thu Sep 12 20:46:58 2024 -0400 fix: upgrade multiple dependencies with Snyk (#30226) Snyk has created this PR to upgrade: - react from 18.2.0 to 18.3.1. See this package in yarn: - react-dom from 18.2.0 to 18.3.1. See this package in yarn: See this project in Snyk: https://app.snyk.io/org/cypress-opensource/project/a5a63d46-02af-48cd-b608-ceae831d3196?utm_source=github&utm_medium=referral&page=upgrade-pr Co-authored-by: snyk-bot <snyk-bot@snyk.io> commit 952c851 Author: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Date: Thu Sep 12 14:14:43 2024 -0400 chore: Update Chrome (stable) to 128.0.6613.137 and Chrome (beta) to 129.0.6668.42 (#30214) * chore: Update Chrome (stable) to 128.0.6613.137 * chore: Update Chrome (stable) to 128.0.6613.137 and Chrome (beta) to 129.0.6668.42 --------- Co-authored-by: cypress-bot[bot] <41898282+cypress-bot[bot]@users.noreply.github.com> Co-authored-by: Jennifer Shehane <jennifer@cypress.io> commit 23e67e1 Author: Raymond Greeley <101662915+raygdev@users.noreply.github.com> Date: Wed Sep 11 11:33:27 2024 -0400 chore(deps): migrate to @tanstack/react-query (#30154) * Migrate to tanstack query * chore(deps): migrate to @tanstack/react-query --------- Co-authored-by: Jennifer Shehane <jennifer@cypress.io>
1 parent 8170e08 commit b0218e5

File tree

19 files changed

+216
-187
lines changed

19 files changed

+216
-187
lines changed

‎.circleci/cache-version.txt

+1-1
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,3 @@
11
# Bump this version to force CI to re-create the cache from scratch.
22

3-
09-17-24
3+
09-17-24-test

‎.circleci/workflows.yml

+2-2
Original file line numberDiff line numberDiff line change
@@ -86,7 +86,7 @@ executors:
8686
# the Docker image with Cypress dependencies and Chrome browser
8787
cy-doc:
8888
docker:
89-
- image: cypress/browsers-internal:node18.17.1-chrome124-ff125
89+
- image: cypress/browsers-internal:node18.17.1-chrome128-ff130
9090
# by default, we use "medium" to balance performance + CI costs. bump or reduce on a per-job basis if needed.
9191
resource_class: medium
9292
environment:
@@ -105,7 +105,7 @@ executors:
105105
# Docker image with non-root "node" user
106106
non-root-docker-user:
107107
docker:
108-
- image: cypress/browsers-internal:node18.17.1-chrome124-ff125
108+
- image: cypress/browsers-internal:node18.17.1-chrome128-ff130
109109
user: node
110110
environment:
111111
PLATFORM: linux

‎browser-versions.json

+2-2
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
{
2-
"chrome:beta": "129.0.6668.29",
3-
"chrome:stable": "128.0.6613.119",
2+
"chrome:beta": "129.0.6668.42",
3+
"chrome:stable": "128.0.6613.137",
44
"chrome:minimum": "64.0.3282.0"
55
}

‎cli/CHANGELOG.md

+5-1
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,11 @@
11
<!-- See the ../guides/writing-the-cypress-changelog.md for details on writing the changelog. -->
22
## 13.14.3
33

4-
_Released 9/10/2024 (PENDING)_
4+
_Released 9/24/2024 (PENDING)_
5+
6+
**Bugfixes:**
7+
8+
- Fixed an issue where Firefox was incorrectly mutating the state of click events on checkboxes after Firefox version `129` and up. Addressed in [#30245](https://github.com/cypress-io/cypress/pull/30245).
59

610
**Dependency Updates:**
711

‎npm/vite-plugin-cypress-esm/cypress/component/edgeCases.cy.tsx

+1-1
Original file line numberDiff line numberDiff line change
@@ -48,7 +48,7 @@ describe('edge cases', () => {
4848
* This library has some weird things going on with prototypes
4949
* under the hood.
5050
*/
51-
it('works with react-query', () => {
51+
it('works with @tanstack/react-query', () => {
5252
mount(<App />)
5353
})
5454

‎npm/vite-plugin-cypress-esm/cypress/component/fixtures/reactQuery.tsx

+2-2
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,7 @@ import {
33
useQueryClient,
44
QueryClient,
55
QueryClientProvider,
6-
} from 'react-query'
6+
} from '@tanstack/react-query'
77
import React from 'react'
88

99
// Create a client
@@ -27,7 +27,7 @@ function Todos () {
2727
const mutation = useMutation(postTodo, {
2828
onSuccess: () => {
2929
// Invalidate and refetch
30-
queryClient.invalidateQueries('todos')
30+
queryClient.invalidateQueries({ queryKey: ['todos'] })
3131
},
3232
})
3333

‎npm/vite-plugin-cypress-esm/package.json

+1-1
Original file line numberDiff line numberDiff line change
@@ -17,11 +17,11 @@
1717
"picomatch": "2.3.0"
1818
},
1919
"devDependencies": {
20+
"@tanstack/react-query": "4.36.1",
2021
"@types/picomatch": "2.3.0",
2122
"@vitejs/plugin-react": "4.3.0",
2223
"react": "16.8.6",
2324
"react-dom": "16.8.6",
24-
"react-query": "3.39.3",
2525
"react-router": "6.10.0",
2626
"react-router-dom": "6.10.0",
2727
"vite": "5.2.11"

‎packages/driver/src/cy/commands/actions/type.ts

+3-2
Original file line numberDiff line numberDiff line change
@@ -192,6 +192,7 @@ export default function (Commands, Cypress, cy, state, config) {
192192
const isFirefoxBefore91 = Cypress.isBrowser('firefox') && Cypress.browserMajorVersion() < 91
193193
const isFirefoxBefore98 = Cypress.isBrowser('firefox') && Cypress.browserMajorVersion() < 98
194194
const isFirefox106OrLater = Cypress.isBrowser('firefox') && Cypress.browserMajorVersion() >= 106
195+
const isFirefox129OrLater = Cypress.isBrowser('firefox') && Cypress.browserMajorVersion() >= 129
195196

196197
const simulateSubmitHandler = function () {
197198
const form = options.$el.parents('form')
@@ -385,9 +386,9 @@ export default function (Commands, Cypress, cy, state, config) {
385386

386387
keydownEvents = []
387388

388-
// After Firefox 98,
389+
// After Firefox 98 and before 129
389390
// Firefox doesn't update checkbox automatically even if the click event is sent.
390-
if (Cypress.isBrowser('firefox')) {
391+
if (Cypress.isBrowser('firefox') && !isFirefox129OrLater) {
391392
if (event.target.type === 'checkbox') {
392393
event.target.checked = !event.target.checked
393394
} else if (event.target.type === 'radio') { // when checked is false, here cannot be reached because of the above condition

‎packages/server/lib/browsers/firefox.ts

+2
Original file line numberDiff line numberDiff line change
@@ -420,6 +420,8 @@ export async function open (browser: Browser, url: string, options: BrowserLaunc
420420
'-marionette',
421421
'-new-instance',
422422
'-foreground',
423+
// if testing against older versions of Firefox to determine when a regression may have been introduced, uncomment the '-allow-downgrade' flag.
424+
// '-allow-downgrade',
423425
'-start-debugger-server', // uses the port+host defined in devtools.debugger.remote
424426
'-no-remote', // @see https://github.com/cypress-io/cypress/issues/6380
425427
],

‎system-tests/__snapshots__/component_testing_spec.ts.js

+2-2
Original file line numberDiff line numberDiff line change
@@ -786,9 +786,9 @@ exports['experimentalSingleTabRunMode / executes all specs in a single tab'] = `
786786
787787
(Screenshots)
788788
789-
- /XXX/XXX/XXX/cypress/screenshots/1_fails.cy.js/simple failing spec -- fails (fai (1280x633)
789+
- /XXX/XXX/XXX/cypress/screenshots/1_fails.cy.js/simple failing spec -- fails (fai (1280x581)
790790
led).png
791-
- /XXX/XXX/XXX/cypress/screenshots/1_fails.cy.js/simple failing spec -- fails agai (1280x633)
791+
- /XXX/XXX/XXX/cypress/screenshots/1_fails.cy.js/simple failing spec -- fails agai (1280x581)
792792
n (failed).png
793793
794794

‎system-tests/__snapshots__/retries_spec.ts.js

+2-2
Original file line numberDiff line numberDiff line change
@@ -164,8 +164,8 @@ exports['retries / supports retries (chrome)'] = `
164164
165165
(Screenshots)
166166
167-
- /XXX/XXX/XXX/cypress/screenshots/fail-twice.cy.js/fail twice (failed).png (1280x633)
168-
- /XXX/XXX/XXX/cypress/screenshots/fail-twice.cy.js/fail twice (failed) (attempt 2 (1280x633)
167+
- /XXX/XXX/XXX/cypress/screenshots/fail-twice.cy.js/fail twice (failed).png (1280x581)
168+
- /XXX/XXX/XXX/cypress/screenshots/fail-twice.cy.js/fail twice (failed) (attempt 2 (1280x581)
169169
).png
170170
171171

‎system-tests/__snapshots__/vite_dev_server_fresh_spec.ts.js

+35-35
Original file line numberDiff line numberDiff line change
@@ -82,7 +82,7 @@ We dynamically generated a new test to display this failure.
8282
8383
(Screenshots)
8484
85-
- /XXX/XXX/XXX/cypress/screenshots/AppCompilationError.cy.jsx/An uncaught error wa (1280x633)
85+
- /XXX/XXX/XXX/cypress/screenshots/AppCompilationError.cy.jsx/An uncaught error wa (1280x581)
8686
s detected outside of a test (failed).png
8787
8888
@@ -165,12 +165,12 @@ https://on.cypress.io/uncaught-exception-from-application
165165
166166
(Screenshots)
167167
168-
- /XXX/XXX/XXX/cypress/screenshots/Errors.cy.jsx/Errors -- error on mount (failed) (1280x633)
168+
- /XXX/XXX/XXX/cypress/screenshots/Errors.cy.jsx/Errors -- error on mount (failed) (1280x581)
169169
.png
170-
- /XXX/XXX/XXX/cypress/screenshots/Errors.cy.jsx/Errors -- sync error (failed).png (1280x633)
171-
- /XXX/XXX/XXX/cypress/screenshots/Errors.cy.jsx/Errors -- async error (failed).pn (1280x633)
170+
- /XXX/XXX/XXX/cypress/screenshots/Errors.cy.jsx/Errors -- sync error (failed).png (1280x581)
171+
- /XXX/XXX/XXX/cypress/screenshots/Errors.cy.jsx/Errors -- async error (failed).pn (1280x581)
172172
g
173-
- /XXX/XXX/XXX/cypress/screenshots/Errors.cy.jsx/Errors -- command failure (failed (1280x633)
173+
- /XXX/XXX/XXX/cypress/screenshots/Errors.cy.jsx/Errors -- command failure (failed (1280x581)
174174
).png
175175
176176
@@ -216,7 +216,7 @@ https://on.cypress.io/uncaught-exception-from-application
216216
217217
(Screenshots)
218218
219-
- /XXX/XXX/XXX/cypress/screenshots/MissingReact.cy.jsx/is missing React (failed).p (1280x633)
219+
- /XXX/XXX/XXX/cypress/screenshots/MissingReact.cy.jsx/is missing React (failed).p (1280x581)
220220
ng
221221
222222
@@ -254,7 +254,7 @@ https://on.cypress.io/uncaught-exception-from-application
254254
255255
(Screenshots)
256256
257-
- /XXX/XXX/XXX/cypress/screenshots/MissingReactInSpec.cy.jsx/is missing React in t (1280x633)
257+
- /XXX/XXX/XXX/cypress/screenshots/MissingReactInSpec.cy.jsx/is missing React in t (1280x581)
258258
his file (failed).png
259259
260260
@@ -485,7 +485,7 @@ We dynamically generated a new test to display this failure.
485485
486486
(Screenshots)
487487
488-
- /XXX/XXX/XXX/cypress/screenshots/AppCompilationError.cy.jsx/An uncaught error wa (1280x633)
488+
- /XXX/XXX/XXX/cypress/screenshots/AppCompilationError.cy.jsx/An uncaught error wa (1280x581)
489489
s detected outside of a test (failed).png
490490
491491
@@ -568,12 +568,12 @@ https://on.cypress.io/uncaught-exception-from-application
568568
569569
(Screenshots)
570570
571-
- /XXX/XXX/XXX/cypress/screenshots/Errors.cy.jsx/Errors -- error on mount (failed) (1280x633)
571+
- /XXX/XXX/XXX/cypress/screenshots/Errors.cy.jsx/Errors -- error on mount (failed) (1280x581)
572572
.png
573-
- /XXX/XXX/XXX/cypress/screenshots/Errors.cy.jsx/Errors -- sync error (failed).png (1280x633)
574-
- /XXX/XXX/XXX/cypress/screenshots/Errors.cy.jsx/Errors -- async error (failed).pn (1280x633)
573+
- /XXX/XXX/XXX/cypress/screenshots/Errors.cy.jsx/Errors -- sync error (failed).png (1280x581)
574+
- /XXX/XXX/XXX/cypress/screenshots/Errors.cy.jsx/Errors -- async error (failed).pn (1280x581)
575575
g
576-
- /XXX/XXX/XXX/cypress/screenshots/Errors.cy.jsx/Errors -- command failure (failed (1280x633)
576+
- /XXX/XXX/XXX/cypress/screenshots/Errors.cy.jsx/Errors -- command failure (failed (1280x581)
577577
).png
578578
579579
@@ -619,7 +619,7 @@ https://on.cypress.io/uncaught-exception-from-application
619619
620620
(Screenshots)
621621
622-
- /XXX/XXX/XXX/cypress/screenshots/MissingReact.cy.jsx/is missing React (failed).p (1280x633)
622+
- /XXX/XXX/XXX/cypress/screenshots/MissingReact.cy.jsx/is missing React (failed).p (1280x581)
623623
ng
624624
625625
@@ -657,7 +657,7 @@ https://on.cypress.io/uncaught-exception-from-application
657657
658658
(Screenshots)
659659
660-
- /XXX/XXX/XXX/cypress/screenshots/MissingReactInSpec.cy.jsx/is missing React in t (1280x633)
660+
- /XXX/XXX/XXX/cypress/screenshots/MissingReactInSpec.cy.jsx/is missing React in t (1280x581)
661661
his file (failed).png
662662
663663
@@ -888,7 +888,7 @@ We dynamically generated a new test to display this failure.
888888
889889
(Screenshots)
890890
891-
- /XXX/XXX/XXX/cypress/screenshots/AppCompilationError.cy.jsx/An uncaught error wa (1280x633)
891+
- /XXX/XXX/XXX/cypress/screenshots/AppCompilationError.cy.jsx/An uncaught error wa (1280x581)
892892
s detected outside of a test (failed).png
893893
894894
@@ -971,12 +971,12 @@ https://on.cypress.io/uncaught-exception-from-application
971971
972972
(Screenshots)
973973
974-
- /XXX/XXX/XXX/cypress/screenshots/Errors.cy.jsx/Errors -- error on mount (failed) (1280x633)
974+
- /XXX/XXX/XXX/cypress/screenshots/Errors.cy.jsx/Errors -- error on mount (failed) (1280x581)
975975
.png
976-
- /XXX/XXX/XXX/cypress/screenshots/Errors.cy.jsx/Errors -- sync error (failed).png (1280x633)
977-
- /XXX/XXX/XXX/cypress/screenshots/Errors.cy.jsx/Errors -- async error (failed).pn (1280x633)
976+
- /XXX/XXX/XXX/cypress/screenshots/Errors.cy.jsx/Errors -- sync error (failed).png (1280x581)
977+
- /XXX/XXX/XXX/cypress/screenshots/Errors.cy.jsx/Errors -- async error (failed).pn (1280x581)
978978
g
979-
- /XXX/XXX/XXX/cypress/screenshots/Errors.cy.jsx/Errors -- command failure (failed (1280x633)
979+
- /XXX/XXX/XXX/cypress/screenshots/Errors.cy.jsx/Errors -- command failure (failed (1280x581)
980980
).png
981981
982982
@@ -1022,7 +1022,7 @@ https://on.cypress.io/uncaught-exception-from-application
10221022
10231023
(Screenshots)
10241024
1025-
- /XXX/XXX/XXX/cypress/screenshots/MissingReact.cy.jsx/is missing React (failed).p (1280x633)
1025+
- /XXX/XXX/XXX/cypress/screenshots/MissingReact.cy.jsx/is missing React (failed).p (1280x581)
10261026
ng
10271027
10281028
@@ -1060,7 +1060,7 @@ https://on.cypress.io/uncaught-exception-from-application
10601060
10611061
(Screenshots)
10621062
1063-
- /XXX/XXX/XXX/cypress/screenshots/MissingReactInSpec.cy.jsx/is missing React in t (1280x633)
1063+
- /XXX/XXX/XXX/cypress/screenshots/MissingReactInSpec.cy.jsx/is missing React in t (1280x581)
10641064
his file (failed).png
10651065
10661066
@@ -1291,7 +1291,7 @@ We dynamically generated a new test to display this failure.
12911291
12921292
(Screenshots)
12931293
1294-
- /XXX/XXX/XXX/cypress/screenshots/AppCompilationError.cy.jsx/An uncaught error wa (1280x633)
1294+
- /XXX/XXX/XXX/cypress/screenshots/AppCompilationError.cy.jsx/An uncaught error wa (1280x581)
12951295
s detected outside of a test (failed).png
12961296
12971297
@@ -1374,12 +1374,12 @@ https://on.cypress.io/uncaught-exception-from-application
13741374
13751375
(Screenshots)
13761376
1377-
- /XXX/XXX/XXX/cypress/screenshots/Errors.cy.jsx/Errors -- error on mount (failed) (1280x633)
1377+
- /XXX/XXX/XXX/cypress/screenshots/Errors.cy.jsx/Errors -- error on mount (failed) (1280x581)
13781378
.png
1379-
- /XXX/XXX/XXX/cypress/screenshots/Errors.cy.jsx/Errors -- sync error (failed).png (1280x633)
1380-
- /XXX/XXX/XXX/cypress/screenshots/Errors.cy.jsx/Errors -- async error (failed).pn (1280x633)
1379+
- /XXX/XXX/XXX/cypress/screenshots/Errors.cy.jsx/Errors -- sync error (failed).png (1280x581)
1380+
- /XXX/XXX/XXX/cypress/screenshots/Errors.cy.jsx/Errors -- async error (failed).pn (1280x581)
13811381
g
1382-
- /XXX/XXX/XXX/cypress/screenshots/Errors.cy.jsx/Errors -- command failure (failed (1280x633)
1382+
- /XXX/XXX/XXX/cypress/screenshots/Errors.cy.jsx/Errors -- command failure (failed (1280x581)
13831383
).png
13841384
13851385
@@ -1425,7 +1425,7 @@ https://on.cypress.io/uncaught-exception-from-application
14251425
14261426
(Screenshots)
14271427
1428-
- /XXX/XXX/XXX/cypress/screenshots/MissingReact.cy.jsx/is missing React (failed).p (1280x633)
1428+
- /XXX/XXX/XXX/cypress/screenshots/MissingReact.cy.jsx/is missing React (failed).p (1280x581)
14291429
ng
14301430
14311431
@@ -1463,7 +1463,7 @@ https://on.cypress.io/uncaught-exception-from-application
14631463
14641464
(Screenshots)
14651465
1466-
- /XXX/XXX/XXX/cypress/screenshots/MissingReactInSpec.cy.jsx/is missing React in t (1280x633)
1466+
- /XXX/XXX/XXX/cypress/screenshots/MissingReactInSpec.cy.jsx/is missing React in t (1280x581)
14671467
his file (failed).png
14681468
14691469
@@ -1906,7 +1906,7 @@ We dynamically generated a new test to display this failure.
19061906
19071907
(Screenshots)
19081908
1909-
- /XXX/XXX/XXX/cypress/screenshots/AppCompilationError.cy.jsx/An uncaught error wa (1280x633)
1909+
- /XXX/XXX/XXX/cypress/screenshots/AppCompilationError.cy.jsx/An uncaught error wa (1280x581)
19101910
s detected outside of a test (failed).png
19111911
19121912
@@ -1989,12 +1989,12 @@ https://on.cypress.io/uncaught-exception-from-application
19891989
19901990
(Screenshots)
19911991
1992-
- /XXX/XXX/XXX/cypress/screenshots/Errors.cy.jsx/Errors -- error on mount (failed) (1280x633)
1992+
- /XXX/XXX/XXX/cypress/screenshots/Errors.cy.jsx/Errors -- error on mount (failed) (1280x581)
19931993
.png
1994-
- /XXX/XXX/XXX/cypress/screenshots/Errors.cy.jsx/Errors -- sync error (failed).png (1280x633)
1995-
- /XXX/XXX/XXX/cypress/screenshots/Errors.cy.jsx/Errors -- async error (failed).pn (1280x633)
1994+
- /XXX/XXX/XXX/cypress/screenshots/Errors.cy.jsx/Errors -- sync error (failed).png (1280x581)
1995+
- /XXX/XXX/XXX/cypress/screenshots/Errors.cy.jsx/Errors -- async error (failed).pn (1280x581)
19961996
g
1997-
- /XXX/XXX/XXX/cypress/screenshots/Errors.cy.jsx/Errors -- command failure (failed (1280x633)
1997+
- /XXX/XXX/XXX/cypress/screenshots/Errors.cy.jsx/Errors -- command failure (failed (1280x581)
19981998
).png
19991999
20002000
@@ -2040,7 +2040,7 @@ https://on.cypress.io/uncaught-exception-from-application
20402040
20412041
(Screenshots)
20422042
2043-
- /XXX/XXX/XXX/cypress/screenshots/MissingReact.cy.jsx/is missing React (failed).p (1280x633)
2043+
- /XXX/XXX/XXX/cypress/screenshots/MissingReact.cy.jsx/is missing React (failed).p (1280x581)
20442044
ng
20452045
20462046
@@ -2078,7 +2078,7 @@ https://on.cypress.io/uncaught-exception-from-application
20782078
20792079
(Screenshots)
20802080
2081-
- /XXX/XXX/XXX/cypress/screenshots/MissingReactInSpec.cy.jsx/is missing React in t (1280x633)
2081+
- /XXX/XXX/XXX/cypress/screenshots/MissingReactInSpec.cy.jsx/is missing React in t (1280x581)
20822082
his file (failed).png
20832083
20842084

0 commit comments

Comments
 (0)