Skip to content

Commit 8a813a6

Browse files
authored
chore: cleaning up the runner container pattern (#18741)
1 parent 081dd19 commit 8a813a6

19 files changed

+43
-74
lines changed

packages/app/src/pages/Index.vue

+26-3
Original file line numberDiff line numberDiff line change
@@ -1,12 +1,35 @@
11
<template>
2-
<div>Home page</div>
2+
<div v-if="query.data.value?.app">
3+
<SpecsList :gql="query.data.value.app" />
4+
</div>
5+
6+
<div v-else>
7+
Loading...
8+
</div>
39
</template>
410

11+
<script lang="ts" setup>
12+
import { gql, useQuery } from '@urql/vue'
13+
import SpecsList from '../specs/SpecsList.vue'
14+
import { SpecsPageContainerDocument } from '../generated/graphql'
15+
16+
gql`
17+
query SpecsPageContainer {
18+
app {
19+
...Specs_SpecsList
20+
}
21+
}
22+
`
23+
24+
const query = useQuery({ query: SpecsPageContainerDocument })
25+
26+
</script>
27+
528
<route>
629
{
7-
name: "Home Page",
30+
name: "Specs Page",
831
meta: {
9-
title: "Home"
32+
title: "Specs"
1033
}
1134
}
1235
</route>
Original file line numberDiff line numberDiff line change
@@ -1,15 +1,14 @@
11
<template>
2-
<div v-if="query.data.value?.app?.activeProject">
3-
<SpecRunnerContainer
4-
:gql="query.data.value.app"
5-
/>
6-
</div>
2+
<SpecRunnerContainer
3+
v-if="query.data.value?.app?.activeProject"
4+
:gql="query.data.value.app"
5+
/>
76
</template>
87

98
<script lang="ts" setup>
109
import { gql, useQuery } from '@urql/vue'
1110
import { SpecPageContainerDocument } from '../generated/graphql'
12-
import SpecRunnerContainer from './SpecRunnerContainer.vue'
11+
import SpecRunnerContainer from '../runner/SpecRunnerContainer.vue'
1312
1413
gql`
1514
query SpecPageContainer {
@@ -21,3 +20,11 @@ query SpecPageContainer {
2120
2221
const query = useQuery({ query: SpecPageContainerDocument })
2322
</script>
23+
24+
<route>
25+
{
26+
meta: {
27+
header: false
28+
}
29+
}
30+
</route>

packages/app/src/pages/Spec.vue

-18
This file was deleted.

packages/app/src/pages/Specs.vue

-16
This file was deleted.
File renamed without changes.

packages/app/src/runner/iframe-model.ts

+1-1
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
import { useSnapshotStore } from '../spec/snapshot-store'
1+
import { useSnapshotStore } from './snapshot-store'
22
import { useAutStore } from '../store'
33

44
export interface AutSnapshot {

packages/app/src/spec/snapshot-store.ts packages/app/src/runner/snapshot-store.ts

+1-1
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
import { defineStore } from 'pinia'
2-
import type { AutSnapshot } from '../runner/iframe-model'
2+
import type { AutSnapshot } from './iframe-model'
33
import { getAutIframeModel } from '../runner'
44

55
export type SnapshotMessageType = 'info' | 'warning' | 'pinned'

packages/app/src/specs/InlineSpecList.vue

+1-1
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,7 @@
55
:key="spec.node.id"
66
class="text-left grid grid-cols-[16px,auto,auto] items-center gap-10px"
77
:class="{ 'border-2 border-red-400': isCurrentSpec(spec) }"
8-
:to="{ path: 'spec', query: { file: spec.node.relative } }"
8+
:to="{ path: 'runner', query: { file: spec.node.relative } }"
99
>
1010
<SpecName :gql="spec.node" />
1111
</RouterLink>

packages/app/src/specs/SpecsList.vue

+1-1
Original file line numberDiff line numberDiff line change
@@ -14,7 +14,7 @@
1414
v-for="spec in filteredSpecs"
1515
:key="spec.node.id"
1616
class="text-left"
17-
:to="{ path: 'spec', query: { file: spec.node.relative } }"
17+
:to="{ path: 'runner', query: { file: spec.node.relative } }"
1818
>
1919
<SpecsListRow :gql="spec" />
2020
</RouterLink>

packages/app/src/specs/SpecsPageContainer.vue

-27
This file was deleted.

0 commit comments

Comments
 (0)