Skip to content

Commit 79b2c38

Browse files
chore: remove cloud connect button from app (#26001)
* chore: remove cloud connect button from app * chore: revert schema changes * chore: revert schemas from develop
1 parent e459591 commit 79b2c38

8 files changed

+6
-474
lines changed

packages/app/cypress/e2e/specs_list_latest_runs.cy.ts

-23
Original file line numberDiff line numberDiff line change
@@ -218,29 +218,6 @@ describe('App/Cloud Integration - Latest runs and Average duration', { viewportW
218218

219219
cy.findByTestId('average-duration-header').trigger('mouseleave')
220220
})
221-
222-
it('shows login/connect button in row when hovering', () => {
223-
cy.get('[data-cy="spec-list-file"] [data-cy="specs-list-row-latest-runs"]')
224-
.eq(0)
225-
.as('latestRunsCell')
226-
.trigger('mouseenter')
227-
228-
cy.contains('[data-cy="specs-list-row-latest-runs"] [data-cy="cloud-button"]', 'Connect').should('be.visible')
229-
230-
cy.get('@latestRunsCell').trigger('mouseleave')
231-
232-
cy.contains('[data-cy="cloud-button"]', 'Connect').should('not.exist')
233-
234-
cy.get('[data-cy="spec-list-file"] [data-cy="specs-list-row-average-duration"]')
235-
.eq(0)
236-
.as('averageDurationCell')
237-
.trigger('mouseenter')
238-
239-
cy.contains('[data-cy="specs-list-row-average-duration"] [data-cy="cloud-button"]', 'Connect').should('be.visible')
240-
cy.get('@averageDurationCell').trigger('mouseleave')
241-
242-
cy.contains('[data-cy="cloud-button"]', 'Connect').should('not.exist')
243-
})
244221
})
245222

246223
context('when project disconnected', () => {

packages/app/src/specs/SpecsList.vue

-14
Original file line numberDiff line numberDiff line change
@@ -140,16 +140,6 @@
140140
/>
141141
</template>
142142

143-
<template #connect-button="{ utmMedium }">
144-
<SpecsListCloudButton
145-
v-if="projectConnectionStatus !== 'CONNECTED' && row.data.isLeaf && row.data.data && (row.data.data.cloudSpec?.data || row.data.data.cloudSpec?.fetchingStatus !== 'FETCHING')"
146-
:gql="props.gql"
147-
:project-connection-status="projectConnectionStatus"
148-
@show-login-connect="openLoginConnectModal({ utmMedium })"
149-
@request-access="requestAccess(props.gql?.currentProject?.projectId)"
150-
/>
151-
</template>
152-
153143
<template #latest-runs>
154144
<div
155145
class="h-full grid justify-items-end items-center relative"
@@ -190,7 +180,6 @@
190180
import SpecsListBanners from './SpecsListBanners.vue'
191181
import LastUpdatedHeader from './LastUpdatedHeader.vue'
192182
import SpecHeaderCloudDataTooltip from './SpecHeaderCloudDataTooltip.vue'
193-
import SpecsListCloudButton from './SpecsListCloudButton.vue'
194183
import SpecsListHeader from './SpecsListHeader.vue'
195184
import SpecListGitInfo from './SpecListGitInfo.vue'
196185
import RunStatusDots from './RunStatusDots.vue'
@@ -212,7 +201,6 @@ import { useRoute } from 'vue-router'
212201
import FlakyInformation from './flaky-badge/FlakyInformation.vue'
213202
import { useCloudSpecData } from '../composables/useCloudSpecData'
214203
import { useSpecFilter } from '../composables/useSpecFilter'
215-
import { useRequestAccess } from '../composables/useRequestAccess'
216204
import { useLoginConnectStore } from '@packages/frontend-shared/src/store/login-connect-store'
217205
import SpecsRunAllSpecs from './SpecsRunAllSpecs.vue'
218206
import { useRunAllSpecsStore } from '../store/run-all-specs-store'
@@ -254,8 +242,6 @@ const hasRequestedAccess = computed(() => {
254242
return projectConnectionStatus.value === 'ACCESS_REQUESTED'
255243
})
256244
257-
const requestAccess = useRequestAccess()
258-
259245
const isGitAvailable = computed(() => {
260246
return !(props.gql.currentProject?.specs.some((s) => s.gitInfo?.statusType === 'noGitInfo') ?? false)
261247
})

packages/app/src/specs/SpecsListCloudButton.cy.tsx

-129
This file was deleted.

packages/app/src/specs/SpecsListCloudButton.vue

-121
This file was deleted.

packages/app/src/specs/SpecsListHoverCell.cy.tsx

-61
This file was deleted.

0 commit comments

Comments
 (0)