Skip to content

Commit 4c45e2e

Browse files
fix: Update Chrome renderer crash to be more terse and up to date (#26597)
1 parent f46acff commit 4c45e2e

File tree

4 files changed

+26
-57
lines changed

4 files changed

+26
-57
lines changed

cli/CHANGELOG.md

+1
Original file line numberDiff line numberDiff line change
@@ -6,6 +6,7 @@ _Released 05/09/2023 (PENDING)_
66
**Bugfixes:**
77

88
- Fixed an issue in Electron where devtools gets out of sync with the DOM occasionally. Addresses [#15932](https://github.com/cypress-io/cypress/issues/15932).
9+
- Updated the Chromium renderer process crash message to be more terse. Addressed in [#26597](https://github.com/cypress-io/cypress/pull/26597).
910

1011
## 12.11.0
1112

packages/errors/__snapshot-html__/RENDERER_CRASHED.html

+7-15
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

packages/errors/src/errors.ts

+6-14
Original file line numberDiff line numberDiff line change
@@ -620,22 +620,14 @@ export const AllCypressErrors = {
620620
return errTemplate`\
621621
We detected that the Chromium Renderer process just crashed.
622622
623-
This is the equivalent to seeing the 'sad face' when Chrome dies.
623+
This can happen for a number of different reasons.
624624
625-
This can happen for a number of different reasons:
625+
If you're running lots of tests on a memory intense application.
626+
- Try increasing the CPU/memory on the machine you're running on.
627+
- Try enabling ${fmt.highlight('experimentalMemoryManagement')} in your config file.
628+
- Try lowering ${fmt.highlight('numTestsKeptInMemory')} in your config file during 'cypress open'.
626629
627-
- You wrote an endless loop and you must fix your own code
628-
- You are running Docker (there is an easy fix for this: see link below)
629-
- You are running lots of tests on a memory intense application.
630-
- Try enabling ${fmt.highlight('experimentalMemoryManagement')} in your config file.
631-
- Try lowering ${fmt.highlight('numTestsKeptInMemory')} in your config file.
632-
- You are running in a memory starved VM environment.
633-
- Try enabling ${fmt.highlight('experimentalMemoryManagement')} in your config file.
634-
- Try lowering ${fmt.highlight('numTestsKeptInMemory')} in your config file.
635-
- There are problems with your GPU / GPU drivers
636-
- There are browser bugs in Chromium
637-
638-
You can learn more including how to fix Docker here:
630+
You can learn more here:
639631
640632
https://on.cypress.io/renderer-process-crashed`
641633
},

system-tests/__snapshots__/browser_crash_handling_spec.js

+12-28
Original file line numberDiff line numberDiff line change
@@ -20,22 +20,14 @@ exports['Browser Crash Handling / when the tab crashes in chrome / fails'] = `
2020
2121
We detected that the Chromium Renderer process just crashed.
2222
23-
This is the equivalent to seeing the 'sad face' when Chrome dies.
23+
This can happen for a number of different reasons.
2424
25-
This can happen for a number of different reasons:
25+
If you're running lots of tests on a memory intense application.
26+
- Try increasing the CPU/memory on the machine you're running on.
27+
- Try enabling experimentalMemoryManagement in your config file.
28+
- Try lowering numTestsKeptInMemory in your config file during 'cypress open'.
2629
27-
- You wrote an endless loop and you must fix your own code
28-
- You are running Docker (there is an easy fix for this: see link below)
29-
- You are running lots of tests on a memory intense application.
30-
- Try enabling experimentalMemoryManagement in your config file.
31-
- Try lowering numTestsKeptInMemory in your config file.
32-
- You are running in a memory starved VM environment.
33-
- Try enabling experimentalMemoryManagement in your config file.
34-
- Try lowering numTestsKeptInMemory in your config file.
35-
- There are problems with your GPU / GPU drivers
36-
- There are browser bugs in Chromium
37-
38-
You can learn more including how to fix Docker here:
30+
You can learn more here:
3931
4032
https://on.cypress.io/renderer-process-crashed
4133
@@ -117,22 +109,14 @@ exports['Browser Crash Handling / when the tab crashes in electron / fails'] = `
117109
118110
We detected that the Chromium Renderer process just crashed.
119111
120-
This is the equivalent to seeing the 'sad face' when Chrome dies.
112+
This can happen for a number of different reasons.
121113
122-
This can happen for a number of different reasons:
123-
124-
- You wrote an endless loop and you must fix your own code
125-
- You are running Docker (there is an easy fix for this: see link below)
126-
- You are running lots of tests on a memory intense application.
127-
- Try enabling experimentalMemoryManagement in your config file.
128-
- Try lowering numTestsKeptInMemory in your config file.
129-
- You are running in a memory starved VM environment.
130-
- Try enabling experimentalMemoryManagement in your config file.
131-
- Try lowering numTestsKeptInMemory in your config file.
132-
- There are problems with your GPU / GPU drivers
133-
- There are browser bugs in Chromium
114+
If you're running lots of tests on a memory intense application.
115+
- Try increasing the CPU/memory on the machine you're running on.
116+
- Try enabling experimentalMemoryManagement in your config file.
117+
- Try lowering numTestsKeptInMemory in your config file during 'cypress open'.
134118
135-
You can learn more including how to fix Docker here:
119+
You can learn more here:
136120
137121
https://on.cypress.io/renderer-process-crashed
138122

0 commit comments

Comments
 (0)