fix(vite-dev-server): do not use incremental esbuild option with Vite v4.2.0+ (#26139)

* fix: do not use `incremental` esbuild option with Vite v4.2.0+

* fix(vite-dev-server): do not use `incremental` esbuild option with Vite v4.2.0+

* feedback

* add changelog entry

* update changelog entry

* remove system test

* invert config logic

* Update cli/CHANGELOG.md

Co-authored-by: Mike Plummer <mike-plummer@users.noreply.github.com>

---------

Co-authored-by: Mike Plummer <mike-plummer@users.noreply.github.com>

Author: astone123

cli/CHANGELOG.md

@@ -1,4 +1,12 @@
 <!-- See the ../guides/writing-the-cypress-changelog.md for details on writing the changelog. -->
+## 12.9.0
+
+_Released 03/28/2023 (PENDING)_
+
+**Bugfixes:**
+
+ - Fixed a compatibility issue so that component test projects can use [Vite](https://vitejs.dev/) version 4.2.0 and greater. Fixes [#26138](https://github.com/cypress-io/cypress/issues/26138).
+
 ## 12.8.1
 
 _Released 03/15/2023_

npm/react/package.json

@@ -28,7 +28,7 @@
     "react-router-dom": "6.0.0-alpha.1",
     "semver": "^7.3.2",
     "typescript": "^4.7.4",
-    "vite": "4.0.1",
+    "vite": "4.2.0",
     "vite-plugin-require-transform": "1.0.3"
   },
   "peerDependencies": {

npm/vite-dev-server/package.json

@@ -18,15 +18,16 @@
   "dependencies": {
     "debug": "^4.3.4",
     "find-up": "6.3.0",
-    "node-html-parser": "5.3.3"
+    "node-html-parser": "5.3.3",
+    "semver": "^7.3.2"
   },
   "devDependencies": {
     "chai": "^4.3.6",
     "dedent": "^0.7.0",
     "mocha": "^9.2.2",
     "sinon": "^13.0.1",
     "ts-node": "^10.9.1",
-    "vite": "4.0.1",
+    "vite": "4.2.0",
     "vite-plugin-inspect": "0.4.3"
   },
   "files": [

npm/vite-dev-server/src/resolveConfig.ts

@@ -6,6 +6,7 @@
 import debugFn from 'debug'
 import type { InlineConfig } from 'vite'
 import path from 'path'
+import semverGte from 'semver/functions/gte'
 
 import { configFiles } from './constants'
 import type { ViteDevServerConfig } from './devServer'
@@ -79,11 +80,13 @@ function makeCypressViteConfig (config: ViteDevServerConfig, vite: Vite): Inline
     paths: [projectRoot],
   })))
 
-  return {
+  const viteConfig: InlineConfig = {
     root: projectRoot,
     base: `${devServerPublicPathRoute}/`,
     optimizeDeps: {
       esbuildOptions: {
+        // We are using Vite 4.2.0+, so `incremental` doesn't exist in the types
+        // @ts-expect-error
         incremental: true,
         plugins: [
           {
@@ -128,4 +131,12 @@ function makeCypressViteConfig (config: ViteDevServerConfig, vite: Vite): Inline
       CypressSourcemap(config, vite),
     ],
   }
+
+  if (vite.version && semverGte(vite.version, '4.2.0')) {
+    // We are using Vite 4.2.0+, so `incremental` doesn't exist in the types
+    // @ts-expect-error
+    delete viteConfig.optimizeDeps?.esbuildOptions?.incremental
+  }
+
+  return viteConfig
 }

npm/vue/package.json

@@ -27,7 +27,7 @@
     "globby": "^11.0.1",
     "tailwindcss": "1.1.4",
     "typescript": "^4.7.4",
-    "vite": "4.0.1",
+    "vite": "4.2.0",
     "vue": "3.2.31",
     "vue-i18n": "9.0.0-rc.6",
     "vue-router": "^4.0.0",

packages/app/package.json

@@ -65,7 +65,7 @@
     "rollup-plugin-polyfill-node": "^0.7.0",
     "unplugin-icons": "0.13.2",
     "unplugin-vue-components": "^0.15.2",
-    "vite": "4.0.1",
+    "vite": "4.2.0",
     "vite-plugin-components": "0.11.3",
     "vite-plugin-pages": "0.18.1",
     "vite-plugin-vue-layouts": "0.6.0",

packages/driver/package.json

@@ -82,7 +82,7 @@
     "unfetch": "4.1.0",
     "url-parse": "1.5.9",
     "vanilla-text-mask": "5.1.1",
-    "vite": "4.0.1",
+    "vite": "4.2.0",
     "webpack": "^4.44.2",
     "zone.js": "0.9.0"
   },

packages/frontend-shared/package.json

@@ -68,7 +68,7 @@
     "shiki": "^0.9.12",
     "unplugin-icons": "0.13.2",
     "unplugin-vue-components": "^0.15.4",
-    "vite": "4.0.1",
+    "vite": "4.2.0",
     "vite-plugin-components": "0.11.3",
     "vite-svg-loader": "3.1.2",
     "vue": "3.2.31",

packages/launchpad/package.json

@@ -63,7 +63,7 @@
     "rimraf": "3.0.2",
     "rollup-plugin-polyfill-node": "^0.7.0",
     "type-fest": "^2.3.4",
-    "vite": "4.0.1",
+    "vite": "4.2.0",
     "vite-plugin-components": "0.11.3",
     "vite-plugin-optimize-persist": "0.0.5",
     "vite-plugin-package-config": "0.0.3",