test(launchpad): fix flaky queries

Closes #23154

Author: jordanpowell88

packages/launchpad/cypress/e2e/config-files-error-handling.cy.ts

@@ -31,7 +31,7 @@ describe('Config files error handling', () => {
 
     cy.findByRole('button', { name: 'Try again' }).click()
 
-    cy.get('h1', { timeout: 10000 }).should('contain', 'Welcome to Cypress')
+    cy.contains('h1', 'Welcome to Cypress')
   })
 
   it('shows the upgrade screen if there is a legacy config file', () => {
@@ -70,7 +70,7 @@ describe('Config files error handling', () => {
 
     cy.findByRole('button', { name: 'Try again' }).click()
 
-    cy.get('h1').should('contain', 'Welcome to Cypress')
+    cy.contains('h1', 'Welcome to Cypress')
   })
 
   it('handles deprecated config fields', () => {
@@ -92,7 +92,7 @@ describe('Config files error handling', () => {
 
     cy.findByRole('button', { name: 'Try again' }).click()
 
-    cy.get('h1', { timeout: 10000 }).should('contain', 'Choose a browser')
+    cy.contains('h1', 'Choose a browser')
   })
 })
 
@@ -165,7 +165,7 @@ describe('Launchpad: Error System Tests', () => {
 
     cy.findByRole('button', { name: 'Try again' }).click()
 
-    cy.get('h1').should('contain', 'Welcome to Cypress')
+    cy.contains('h1', 'Welcome to Cypress')
   })
 
   it(`clears the error correctly after first 'try again' attempt`, () => {
@@ -190,7 +190,7 @@ describe('Launchpad: Error System Tests', () => {
 
     cy.findByRole('button', { name: 'Try again' }).click()
 
-    cy.get('h1').should('contain', 'Welcome to Cypress')
+    cy.contains('h1', 'Welcome to Cypress')
   })
 
   it('shows correct user file instead of node file', () => {
@@ -279,7 +279,7 @@ describe('setupNodeEvents', () => {
 
     cy.findByRole('button', { name: 'Try again' }).click()
 
-    cy.get('h1', { timeout: 10000 }).should('contain', 'Choose a browser')
+    cy.contains('h1', 'Choose a browser')
   })
 
   it('handles multiple config errors and then recovers', () => {
@@ -310,7 +310,7 @@ describe('setupNodeEvents', () => {
     })
 
     cy.findByRole('button', { name: 'Try again' }).click()
-    cy.get('h1', { timeout: 10000 }).should('contain', 'Choose a browser')
+    cy.contains('h1', 'Choose a browser')
     cy.get('[data-cy="alert"]').should('contain', 'Warning: Cannot Connect Base Url Warning')
   })
 

packages/launchpad/cypress/e2e/config-warning.cy.ts

@@ -232,7 +232,7 @@ describe('component testing dependency warnings', () => {
     cy.skipWelcome()
     cy.contains('component-testing-outdated-dependencies').click()
     cy.get('[data-cy="warning-alert"]').should('not.exist')
-    cy.get('a').contains('Projects').click()
+    cy.contains('a', 'Projects').click()
     cy.get('[data-cy-testingtype="component"]').click()
     cy.get('[data-cy="warning-alert"]', { timeout: 12000 }).should('exist')
     .should('contain.text', 'Warning: Component Testing Mismatched Dependencies')
@@ -243,7 +243,6 @@ describe('component testing dependency warnings', () => {
     cy.get('.warning-markdown').find('li').should('have.length', 3)
   })
 
-  // TODO: fix flaky test https://github.com/cypress-io/cypress/issues/23154
   it('warns against outdated @vue/cli dependency', { retries: 15 }, () => {
     cy.scaffoldProject('outdated-deps-vuecli3')
     cy.addProject('outdated-deps-vuecli3')
@@ -252,7 +251,7 @@ describe('component testing dependency warnings', () => {
     cy.skipWelcome()
     cy.contains('outdated-deps-vuecli3').click()
     cy.get('[data-cy="warning-alert"]').should('not.exist')
-    cy.get('a').contains('Projects').click()
+    cy.contains('a', 'Projects').click()
     cy.get('[data-cy-testingtype="component"]').click()
     cy.get('[data-cy="warning-alert"]', { timeout: 12000 }).should('exist')
     .should('contain.text', 'Warning: Component Testing Mismatched Dependencies')