Skip to content

Commit 085bc1e

Browse files
github-actions[bot]cypress-bot[bot]emilyrohrboughchrisbreiding
authoredSep 21, 2022
chore: Update Chrome (stable) to 105.0.5195.125 and Chrome (beta) to 106.0.5249.30 (#23421)
Co-authored-by: cypress-bot[bot] <2f0651858c6e38e0+cypress-bot[bot]@users.noreply.github.com> Co-authored-by: Emily Rohrbough <emilyrohrbough@users.noreply.github.com> Co-authored-by: Chris Breiding <chrisbreiding@gmail.com>
1 parent 3c81140 commit 085bc1e

File tree

3 files changed

+15
-7
lines changed

3 files changed

+15
-7
lines changed
 

‎browser-versions.json

+2-2
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
{
2-
"chrome:beta": "105.0.5195.28",
3-
"chrome:stable": "104.0.5112.101",
2+
"chrome:beta": "106.0.5249.30",
3+
"chrome:stable": "105.0.5195.125",
44
"chrome:minimum": "64.0.3282.0"
55
}

‎scripts/github-actions/update-browser-versions.js

+4-3
Original file line numberDiff line numberDiff line change
@@ -77,13 +77,14 @@ const checkNeedForBranchUpdate = ({ core, latestStableVersion, latestBetaVersion
7777
}
7878

7979
const updateBrowserVersionsFile = ({ latestBetaVersion, latestStableVersion }) => {
80-
const versions = {
80+
const currentBrowserVersions = JSON.parse(fs.readFileSync('./browser-versions.json'))
81+
const newVersions = Object.assign(currentBrowserVersions, {
8182
'chrome:beta': latestBetaVersion,
8283
'chrome:stable': latestStableVersion,
83-
}
84+
})
8485

8586
// file path is relative to repo root
86-
fs.writeFileSync('./browser-versions.json', `${JSON.stringify(versions, null, 2) }\n`)
87+
fs.writeFileSync('./browser-versions.json', `${JSON.stringify(newVersions, null, 2) }\n`)
8788
}
8889

8990
const updatePRTitle = async ({ context, github, baseBranch, branchName, description }) => {

‎scripts/unit/github-actions/update-browser-version-spec.js

+9-2
Original file line numberDiff line numberDiff line change
@@ -246,7 +246,13 @@ describe('update browser version github action', () => {
246246
})
247247

248248
context('.updateBrowserVersionsFile', () => {
249-
it('updates browser-versions.json with specified versions', () => {
249+
it('updates browser-versions.json with specified versions, leaving other entries in place', () => {
250+
sinon.stub(fs, 'readFileSync').returns(`{
251+
"chrome:beta": "1.1",
252+
"chrome:stable": "1.0",
253+
"chrome:other": "0.4"
254+
}`)
255+
250256
sinon.stub(fs, 'writeFileSync')
251257

252258
updateBrowserVersionsFile({
@@ -256,7 +262,8 @@ describe('update browser version github action', () => {
256262

257263
expect(fs.writeFileSync).to.be.calledWith('./browser-versions.json', `{
258264
"chrome:beta": "2.1",
259-
"chrome:stable": "2.0"
265+
"chrome:stable": "2.0",
266+
"chrome:other": "0.4"
260267
}
261268
`)
262269
})

0 commit comments

Comments
 (0)