Skip to content

Commit 0e0474e

Browse files
AtofStrykerAtofStryker
authored
Chore: update node18 and sync todomvc app (#277)
* chore: update to node18 * chore: update typescript from 3x to 5x * chore: update http server from 0.13.0 to 14.1.1 * chore: update the TODO-MVC app based off of tastejs/todomvc@c50cc92 * chore: update cypress related dependencies for todomvc * fix githubv script * chore: fix types and add cross-env ot run windows scripts * chore: no longer lint js files as we have ts/tsx files
1 parent 1729b89 commit 0e0474e

21 files changed

+3614
-1238
lines changed

‎.github/workflows/main.yml

+1-1
Original file line numberDiff line numberDiff line change
@@ -9,5 +9,5 @@ jobs:
99
- name: Run E2E tests
1010
uses: cypress-io/github-action@v5
1111
with:
12-
start: npm run start:ci
12+
start: npm run start
1313
wait-on: http://localhost:8888

‎.gitignore

+1
Original file line numberDiff line numberDiff line change
@@ -27,3 +27,4 @@ build/Release
2727
node_modules
2828
cypress/videos
2929
cypress/screenshots
30+
js/*.js

‎.node-version

+1-1
Original file line numberDiff line numberDiff line change
@@ -1 +1 @@
1-
16.16.0
1+
18.16.1

‎cypress/support/index.d.ts

-8
Original file line numberDiff line numberDiff line change
@@ -22,13 +22,5 @@ declare namespace Cypress {
2222
* cy.v()
2323
*/
2424
addAxeCode(): Chainable<any>
25-
26-
/**
27-
* Run a11y tests or only a subset of all tests
28-
* @see https://github.com/avanslaars/cypress-axe
29-
* @example
30-
* cy.checkA11y()
31-
*/
32-
checkA11y(any, object): Chainable<any>
3325
}
3426
}

‎index.html

+4-16
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
<!doctype html>
2-
<html lang="en" data-framework="react">
2+
<html lang="en" data-framework="typescript">
33
<head>
44
<meta charset="utf-8">
55
<title>React • TodoMVC</title>
@@ -10,22 +10,10 @@
1010
<section class="todoapp"></section>
1111
<footer class="info">
1212
<p>Double-click to edit a todo</p>
13-
<p>Created by <a href="http://github.com/petehunt/">petehunt</a></p>
13+
<p>Created by <a href="http://github.com/remojansen/">Remo H. Jansen</a></p>
1414
<p>Part of <a href="http://todomvc.com">TodoMVC</a></p>
1515
</footer>
16-
17-
<script src="node_modules/todomvc-common/base.js"></script>
18-
<script src="node_modules/react/dist/react-with-addons.js"></script>
19-
<script src="node_modules/react/dist/JSXTransformer.js"></script>
20-
<script src="node_modules/director/build/director.js"></script>
21-
22-
<script src="js/utils.js"></script>
23-
<script src="js/todoModel.js"></script>
24-
<!-- jsx is an optional syntactic sugar that transforms methods in React's
25-
`render` into an HTML-looking format. Since the two models above are
26-
unrelated to React, we didn't need those transforms. -->
27-
<script type="text/jsx" src="js/todoItem.jsx"></script>
28-
<script type="text/jsx" src="js/footer.jsx"></script>
29-
<script type="text/jsx" src="js/app.jsx"></script>
16+
<script type="text/javascript" src="node_modules/director/build/director.js"></script>
17+
<script type="text/javascript" src="js/bundle.js"></script>
3018
</body>
3119
</html>

‎js/app.jsx

-175
This file was deleted.

0 commit comments

Comments
 (0)