Merge pull request #15 from cybercoder-naj/fix/file-logging

Fix file logging

Author: cybercoder-naj

CHANGELOG.md

@@ -1,4 +1,8 @@
 # CHANGELOG
+## [1.0.0-alpha.6] - 26-03-2024
+### Fixed
+- Fix issues related to file logging. ([#14](https://github.com/cybercoder-naj/logestic/issues/14))
+
 ## [1.0.0-alpha.5] - 26-03-2024
 ### Changed
 - Request duration returns time in microseconds.

package.json

@@ -1,6 +1,6 @@
 {
   "name": "logestic",
-  "version": "1.0.0-alpha.5",
+  "version": "1.0.0-alpha.6",
   "author": "Nishant Aanjaney Jalan <cybercoder.nishant@gmail.com>",
   "description": "An advanced and customisable logging library for ElysiaJS",
   "keywords": [

preview/.gitignore

@@ -0,0 +1 @@
+*.log

preview/bun.lockb

@@ -18,6 +18,6 @@
   "homepage": "https://github.com/cybercoder-naj/logestic#readme",
   "dependencies": {
     "elysia": "^1.0.0",
-    "logestic": ".."
+    "logestic": "file:.."
   }
 }

preview/package.json

@@ -2,7 +2,7 @@ import { Elysia } from 'elysia';
 import { Logestic } from 'logestic';
 
 const app = new Elysia()
-  .use(Logestic.preset('common', { showType: true }))
+  .use(Logestic.preset('fancy'))
   .get('/', () => 'Hello, world!')
   .get('/hello/:name', ({ params: { name } }) => `Hello, ${name}!`)
   .get('/returnBad', ({ set }) => {

preview/src/index.ts

@@ -13,8 +13,9 @@ import {
 } from './types';
 import { BunFile } from 'bun';
 import c from 'chalk';
-import { buildAttrs, colourLogType } from './utils';
+import { buildAttrs, colourLogType, removeAnsi } from './utils';
 import { getPreset } from './presets';
+import fs from 'node:fs';
 
 export type { Attribute, LogesticOptions };
 export const chalk = c; // Re-export chalk for custom formatting
@@ -62,11 +63,15 @@ export class Logestic {
     }
 
     // Custom file destination
-    this.dest = this.createFileIfNotExists(dest);
+    this.createFileIfNotExists(dest)
+      .then(file => (this.dest = file))
+      .catch(err => {
+        throw err;
+      });
   }
 
-  private createFileIfNotExists(dest: BunFile): BunFile {
-    if (!dest.exists()) {
+  private async createFileIfNotExists(dest: BunFile): Promise<BunFile> {
+    if (!(await dest.exists())) {
       Bun.write(dest, '');
     }
     return dest;
@@ -156,21 +161,19 @@ export class Logestic {
   }
 
   private async log(msg: string): Promise<void> {
-    let content: string | undefined = undefined;
-    // Get the content of the file if it is not stdout
-    // Possible race condition in the file for multiple requests
-    if (this.dest !== Bun.stdout) {
-      content = await this.dest.text();
+    const msgNewLine = `${msg}\n`;
+    if (!this.dest.name || !this.dest.name.length) {
+      // This is either stdout or stderr
+      Bun.write(this.dest, msgNewLine);
+      return;
     }
 
-    // Append the log message
-    const writer = this.dest.writer();
-    if (content) {
-      writer.write(content);
-    }
-    writer.write(msg);
-    writer.write('\n');
-    writer.flush();
+    const sanitised = removeAnsi(msgNewLine);
+    fs.appendFile(this.dest.name, sanitised, err => {
+      if (err) {
+        throw err;
+      }
+    });
   }
 
   /**

src/index.ts

@@ -116,3 +116,7 @@ export const colourLogType = (
   const withSpaces = ` ${type.toUpperCase()} `;
   return bgColour?.(withSpaces) ?? withSpaces;
 };
+
+export function removeAnsi(text: string): string {
+  return text.replace(/\u001b\[\d*m/g, '').trimStart();
+}