Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Table Message Variant refactor #1533

Closed
ctm opened this issue Jan 5, 2025 · 1 comment
Closed

Table Message Variant refactor #1533

ctm opened this issue Jan 5, 2025 · 1 comment
Assignees
@ctm
Labels
chore Maintenance or other non-bug, non-feature easy Trivial to do (even when tired!) and semi-worthwhile high priority Should be done fairly soon

Comments

@ctm
Copy link
Owner

ctm commented Jan 5, 2025

Make a TableMessageVariant repr(i16) enum and then use it in our various models, etc.

This is a step toward hand histories (#576) that I've already done. I want it in its own commit and as its own issue though because we may want to use the same technique for the other three messages (private table messages and public and private lobby messages).
@ctm ctm added chore Maintenance or other non-bug, non-feature high priority Should be done fairly soon easy Trivial to do (even when tired!) and semi-worthwhile labels Jan 5, 2025
@ctm ctm self-assigned this Jan 5, 2025
@ctm
Copy link
Owner Author

ctm commented Jan 5, 2025

Deployed.

@ctm ctm closed this as completed Jan 5, 2025
@ctm ctm mentioned this issue Feb 6, 2025
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ctm ctm

Labels
chore Maintenance or other non-bug, non-feature easy Trivial to do (even when tired!) and semi-worthwhile high priority Should be done fairly soon
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@ctm