Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

switch from num_enum to derive_more #1532

Closed
ctm opened this issue Jan 5, 2025 · 1 comment
Closed

switch from num_enum to derive_more #1532

ctm opened this issue Jan 5, 2025 · 1 comment
Assignees
@ctm
Labels
chore Maintenance or other non-bug, non-feature easy Trivial to do (even when tired!) and semi-worthwhile high priority Should be done fairly soon

Comments

@ctm
Copy link
Owner

ctm commented Jan 5, 2025

Switch from num_enum to derive_more.

The actix ecosystem already uses derive_more and our use of nun_enum is extremely limited to functionality that is in derive_more, so it makes sense to switch now.

FWIW, this caught my attention as I was working on #576, where I'm minorly refactoring variants (although not the actual values).
@ctm ctm added chore Maintenance or other non-bug, non-feature high priority Should be done fairly soon easy Trivial to do (even when tired!) and semi-worthwhile labels Jan 5, 2025
@ctm ctm self-assigned this Jan 5, 2025
@ctm
Copy link
Owner Author

ctm commented Jan 5, 2025

Done and deployed.

@ctm ctm closed this as completed Jan 5, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ctm ctm

Labels
chore Maintenance or other non-bug, non-feature easy Trivial to do (even when tired!) and semi-worthwhile high priority Should be done fairly soon
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@ctm