-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Client panicked #1509
Comments
This happened again today.
|
Going through my email, I found that a player reported this at 6:27, September 29th. I don't have an exact hand number, but poking around in the database should allow me to find it. I'm going to take the time to find hand numbers so that I can see if it's always the same game or at least same type of game. It's a bit late to get more info from the affected players, but I still plan to capture backtraces (#1508) "soon", so if I can't figure out what's going on via code inspection, that's OK, I guess. |
FTR, the September 29th panic was in a HOSER tournament in Stud/8, where the person who got the panic was the bring-in:
Interestingly enough, this was the first hand at that table (6081), which had been cleaved off 6080. Here are the messages associated with creation:
Here's the previous hand at table 6080:
It's interesting that the player was moved in the middle of a hand. That player's chips were still in the pot on table 6080. IIRC, chips now belong to seats, not players, so that shouldn't be a problem, but if the other instances of this panic are also the first hand of a new table, that will be a pretty big tell. |
FWIW, the report in the description came to me via a text message at 18:24, Wednesday, November 13th. It was accompanied by the text
I strongly suspect it was this hand:
This happens to be the first Stud/8 hand of a new table. I have one more panic to investigate, but it seems pretty likely that there's a bug that affects the first hand of a split table, quite possibly only when it's Stud or Stud/8. |
The third panic is completely dissimilar. It occurs in a
Since the Here is the entire preceding hand and the beginning of the hand up until
I will need to poke around in the database to see if there's any sign of the table being closed and then reopened, because I'm guessing that this is a different bug and it may not even be a panic. The only thing special about the previous hand is that there were redemptions happening when it was dan's turn to act. However, two seconds before timing out, we received a message, which could mean that he was distracted while typing a chat or could mean that network lag made his client briefly unresponsive. Neither of those are panics and both are known "issues". |
So, Dan did close and get a new window after his forced vacation, but that doesn't mean he necessarily got a panic. If he was lagged, he might close the window, knowing that clears problems. It's been almost two weeks though, so my inclination is to add the code to report panic backtraces (#1508), then look to see if I can see anything that explains why the first hand of stud on a new table might cause a panic, but to not look further into this |
FWIW, I took a tiny poke at this one by creating a I wouldn't normally be working on this issue, but I had a tiny bit of time to kill and was hoping that I'd trigger the bug on the first try. I've left the branch around in case I want to try a few more iterations of reproducing it, but if it happens again IRL, the code that I've added to report client problems should give me enough information to track this down trivially. |
Try to figure out why a user got this error message:
I am pretty sure that's just what people see when the client panics. I'll be double-checking that "soon". I have the timestamp for when this was reported, so I should be able to figure out which hand this happened on. In the future, we'll have panics report a backtrace (#1508), but that's unavailable for this one.
FWIW, there have been occasional reports of similar problems in the past and I thought we had an open issue for them, but I wasn't able to find one. They're pretty rare, probably around one a month, but considering we only play one tournament a day these days, that's still way too frequent.
The text was updated successfully, but these errors were encountered: