Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for 0.6 features #405

Closed
montyly opened this issue Mar 6, 2020 · 2 comments
Closed

Add support for 0.6 features #405

montyly opened this issue Mar 6, 2020 · 2 comments
Labels
enhancement New feature or request

Comments

@montyly
Copy link
Member

montyly commented Mar 6, 2020

https://solidity.readthedocs.io/en/v0.6.3/060-breaking-changes.html#solidity-v0-6-0-breaking-changes

Among others:

  • Functions override (virtual , override)
  • abstract contract
  • receive / fallback function
  • payable type conversion
  • try/catch statement
@elenadimitrova
Copy link

elenadimitrova commented Jun 17, 2020

Just got a false positive for the following try/catch statement we added:

        uint256 decimals;
        try IERC20Extended(_token).decimals() returns (uint _decimals) {
            decimals = _decimals;
        } 
        catch (bytes memory /*lowLevelData*/) {
        }

Error:

TokenPriceProvider.getEtherValue(uint256,address) (modules/common/TokenPriceProvider.sol#33-46)
ignores return value by IERC20Extended(_token).decimals()
(modules/common/TokenPriceProvider.sol#36-41)

@montyly
Copy link
Member Author

montyly commented Jun 18, 2020

Hi @elenadimitrova . Thanks for reporting this. I am tracking it in #511, and will fix it as soon as possible.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants