Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Problem: no integration test for block gas limit #293

Closed
yihuang opened this issue Jan 5, 2022 · 1 comment
Closed

Problem: no integration test for block gas limit #293

yihuang opened this issue Jan 5, 2022 · 1 comment
Labels
tests This issue is related to unit or integration tests

Comments

@yihuang
Copy link
Collaborator

yihuang commented Jan 5, 2022 •
edited
Loading

we fixed two issues regarding block gas limit, good to add regression integration test case:

  • tx should revert when exceeds block gas limit
  • RPC should report correct block gas used when block gas limit is exceeded.
@yihuang yihuang added the tests This issue is related to unit or integration tests label Feb 15, 2022
@yihuang
Copy link
Collaborator Author

yihuang commented Mar 9, 2022 •
edited
Loading

After the gas meter issue is fixed: #378, it won't include the transactions that exceed the block gas limit in the first place.
So may be difficult to test this scenario in integration tests, closing now.

@yihuang yihuang closed this as completed Mar 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
tests This issue is related to unit or integration tests
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@yihuang