This repository has been archived by the owner on Oct 22, 2019. It is now read-only.
Internal refactoring and documentation #3
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Robert Vojta <rvojta@me.com>
Signed-off-by: Robert Vojta <rvojta@me.com>
Signed-off-by: Robert Vojta <rvojta@me.com>
Signed-off-by: Robert Vojta <rvojta@me.com>
Signed-off-by: Robert Vojta <rvojta@me.com>
Signed-off-by: Robert Vojta <rvojta@me.com>
Signed-off-by: Robert Vojta <rvojta@me.com>
Signed-off-by: Robert Vojta <rvojta@me.com>
Signed-off-by: Robert Vojta <rvojta@me.com>
Signed-off-by: Robert Vojta <rvojta@me.com>
Signed-off-by: Robert Vojta <rvojta@me.com>
zrzka
changed the title
|
@TimonPost removed |
|
@TimonPost err, taking back, I forgot about the |
Signed-off-by: Robert Vojta <rvojta@me.com>
Signed-off-by: Robert Vojta <rvojta@me.com>
|
Fixed, ready. |
Signed-off-by: Robert Vojta <rvojta@me.com>
Signed-off-by: Robert Vojta <rvojta@me.com>
TimonPost
reviewed
Sep 27, 2019
src/lib.rs
Outdated
| /// - Raw screen | ||
| /// - Exit the current process | ||
| /// | ||
| /// Check `/examples/` in the library for more specific examples. |
There was a problem hiding this comment.
Seems like an outdated comment?
| ```toml | ||
| [dependencies] | ||
| # All crossterm features are enabled by default. | ||
| crossterm = "0.11" |
There was a problem hiding this comment.
This is intentional. See the cursor's Getting started. Same here. Why intentional? Yep, it's a crossterm_terminal crate, but I kind of want to "force" users to use crossterm crate.
| }; | ||
|
|
||
| if clear_type == ClearType::All { |
There was a problem hiding this comment.
I am unsure if this is really needed here. Maybe we should re-validate this.
There was a problem hiding this comment.
Then we should create an issue for this as this PR goal is no breaking / functional changes at all. Just internal refactor & docs.
Signed-off-by: Robert Vojta <rvojta@me.com>
43 tasks
Signed-off-by: Robert Vojta <rvojta@me.com>
Signed-off-by: Robert Vojta <rvojta@me.com>
Signed-off-by: Robert Vojta <rvojta@me.com>
Signed-off-by: Robert Vojta <rvojta@me.com>
Signed-off-by: Robert Vojta <rvojta@me.com>
TimonPost
approved these changes
Sep 30, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
.travis.ymlupdated to build PRs &masterbranch onlyunused_must_usewarning -> error#[doc(no_inline)])-cursor(& no breaking changes)