-
Notifications
You must be signed in to change notification settings - Fork 41
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
update crossplane-runtime to v1.15.2 #110
update crossplane-runtime to v1.15.2 #110
Conversation
This is currently not possible to compile because |
i know ;) thats why its a draft - but with this branch we can use provider-argocd in functions |
// server. Switching to Leases only and longer leases appears to | ||
// alleviate this. | ||
LeaderElection: *leaderElection, | ||
LeaderElectionID: "crossplane-leader-election-provider-aws", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
should be argocd
I think if that will be merged, the crossplane-runtime update should work quite well. All the replace's in the mod-file could be removed… |
Crossplane does not currently have enough maintainers to address every issue and pull request. This pull request has been automatically marked as |
/fresh |
cb755b0
to
65d04aa
Compare
I have made the code compile by replacing Since we are not using the gitops-engine itself and only use the API types I think it is safe to merge this. |
97932dd
to
e51c21d
Compare
Signed-off-by: Christopher Haar <christopher.haar@upbound.io>
e51c21d
to
ce6afe8
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. I fixed the remaining issues myself. Thanks a lot @haarchri!
Description of your changes
Fixes #
I have:
make reviewable test
to ensure this PR is ready for review.How has this code been tested