Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update crossplane-runtime to v1.15.2 #110

Merged
merged 1 commit into from
Apr 29, 2024

Conversation

haarchri
Copy link
Member

@haarchri haarchri commented Nov 6, 2023

Description of your changes

Fixes #

I have:

  • Read and followed Crossplane's contribution process.
  • Run make reviewable test to ensure this PR is ready for review.

How has this code been tested

@MisterMX
Copy link
Collaborator

MisterMX commented Dec 4, 2023

This is currently not possible to compile because github.com/argoproj/argo-cd/v2 uses an older version of k8s.io/client-go that breaks with the one that is used in github.com/crossplane/crossplane-runtime.

@haarchri
Copy link
Member Author

haarchri commented Dec 4, 2023

i know ;) thats why its a draft - but with this branch we can use provider-argocd in functions

// server. Switching to Leases only and longer leases appears to
// alleviate this.
LeaderElection: *leaderElection,
LeaderElectionID: "crossplane-leader-election-provider-aws",
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should be argocd

@maximilianbraun
Copy link
Contributor

I think if that will be merged, the crossplane-runtime update should work quite well. All the replace's in the mod-file could be removed…
argoproj/gitops-engine#556

Copy link

Crossplane does not currently have enough maintainers to address every issue and pull request. This pull request has been automatically marked as stale because it has had no activity in the last 90 days. It will be closed in 7 days if no further activity occurs. closed in 7 days if no further activity occurs. Adding a comment starting with /fresh will mark this PR as not stale.

@github-actions github-actions bot added the stale label Mar 21, 2024
@MisterMX
Copy link
Collaborator

/fresh

@github-actions github-actions bot removed the stale label Mar 21, 2024
@MisterMX MisterMX force-pushed the feature/runtime-update branch 3 times, most recently from cb755b0 to 65d04aa Compare April 25, 2024 17:32
@MisterMX
Copy link
Collaborator

I have made the code compile by replacing github.com/argoproj/gitops-engine with asaf-erlich/gitops-engine@1c9f565 which is the WIP in argoproj/gitops-engine#565.

Since we are not using the gitops-engine itself and only use the API types I think it is safe to merge this.

@MisterMX MisterMX force-pushed the feature/runtime-update branch 7 times, most recently from 97932dd to e51c21d Compare April 29, 2024 12:24
@MisterMX MisterMX changed the title update crossplane-runtime to v1.14.1 update crossplane-runtime to v1.15.2 Apr 29, 2024
@MisterMX MisterMX marked this pull request as ready for review April 29, 2024 12:34
Signed-off-by: Christopher Haar <christopher.haar@upbound.io>
@MisterMX MisterMX force-pushed the feature/runtime-update branch from e51c21d to ce6afe8 Compare April 29, 2024 14:01
Copy link
Collaborator

@MisterMX MisterMX left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. I fixed the remaining issues myself. Thanks a lot @haarchri!

@MisterMX MisterMX merged commit 82346ac into crossplane-contrib:main Apr 29, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants