This repository has been archived by the owner on Nov 5, 2018. It is now read-only.
Update the implementation of unprotected scope #13
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
approved these changes
Sep 6, 2017
src/mutator.rs
Outdated
| unsafe fn get_bag(&self) -> &mut Bag { | ||
| &mut *self.bag | ||
| #[inline] | ||
| unsafe fn get_bag(&self) -> Option<&mut Bag> { |
There was a problem hiding this comment.
This can be just:
#[inline]
unsafe fn get_bag(&self) -> Option<&mut Bag> {
self.bag.as_mut()
}There was a problem hiding this comment.
Or, alternatively, delete this method and instead of calling self.get_bag() just write self.bag.as_mut() :)
|
@stjepang thanks! I removed |
ghost
merged commit
This pull request was closed.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a subset of RFC #10 (crossbeam-rs/rfcs#10). It doesn't change any interface, so I would like to post this PR without going for RFC.
In short, it implements @stjepang 's suggestion (crossbeam-rs/rfcs#10 (comment)):
unprotectedscope has a null bag, and garbages created within this scope are immediately disposed of.