Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ClientState is stored in the privateStore in the standard, but is provable in ibc-go #764

Closed
plafer opened this issue Jun 1, 2022 · 3 comments · Fixed by #802
Closed

Comments

@plafer
Copy link
Contributor

plafer commented Jun 1, 2022

ibc-go returns a proof in QueryClientStateResponse, suggesting that ClientState is stored in the provableStore, whereas the standard claims that ClientState is stored in privateStore (see ICS-24 and ICS-2).

The standard should probably be adjusted to remove this inconsistency.

@plafer
Copy link
Contributor Author

plafer commented Jun 1, 2022

Moreover, ibc-go relies on a proven ClientState for its ConnOpenTry() and ConnOpenAck() handlers, whereas the standard doesn't.

@AdityaSripal
Copy link
Member

Indeed the clientstate must be stored in the public store.

Also, definitely need to add the client verification from ibc-go into the standard. Not sure why this was missed.

Thanks @plafer for finding these! Are you interested in submitting the fixes?

@plafer
Copy link
Contributor Author

plafer commented Jun 24, 2022

Yes sure I can do that!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Backlog
Development

Successfully merging a pull request may close this issue.

2 participants