Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Document that if the host fails to execute a single message, none of the messages sent by the controller in a single packet are committed #693

Closed
2 of 3 tasks
crodriguezvega opened this issue Jan 7, 2022 · 0 comments · Fixed by #719
Closed
2 of 3 tasks

Document that if the host fails to execute a single message, none of the messages sent by the controller in a single packet are committed #693

crodriguezvega opened this issue Jan 7, 2022 · 0 comments · Fixed by #719
Assignees
@damiannolan
Labels
27-interchain-accounts audit Feedback from implementation audit docs Improvements or additions to documentation
Milestone
Interchain Accounts

Comments

@crodriguezvega
Copy link
Contributor

This issue was found by Trail of Bits during the audit of ICS27 Interchain Accounts

Problem Definition

The executeTx function, which validates and executes the received messages on the host chain, errors out if the validation or execution of any message fails; if the function errors out for this reason, it does not commit any of the state changes.

Proposal

Add to the documentation that this is the expected behavior.

For Admin Use

  • Not duplicate issue
  • Appropriate labels applied
  • Appropriate contributors tagged/assigned
@crodriguezvega crodriguezvega added 27-interchain-accounts audit Feedback from implementation audit labels Jan 7, 2022
@crodriguezvega crodriguezvega added this to the Interchain Accounts milestone Jan 7, 2022
@crodriguezvega crodriguezvega moved this to Backlog in ibc-go Jan 7, 2022
@crodriguezvega crodriguezvega added the docs Improvements or additions to documentation label Jan 7, 2022
@crodriguezvega crodriguezvega moved this from Backlog to Todo in ibc-go Jan 10, 2022
@damiannolan damiannolan self-assigned this Jan 12, 2022
@crodriguezvega crodriguezvega moved this from Todo to In progress in ibc-go Jan 12, 2022
@damiannolan damiannolan mentioned this issue Jan 12, 2022
Merged
9 tasks
@damiannolan damiannolan moved this from In progress to In review in ibc-go Jan 13, 2022
Repository owner moved this from In review to Done in ibc-go Jan 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@damiannolan damiannolan

Labels
27-interchain-accounts audit Feedback from implementation audit docs Improvements or additions to documentation
Projects
No open projects
ibc-go
Archived in project
Milestone
Interchain Accounts
Development

Successfully merging a pull request may close this issue.

docs: ica tx atomicity docs and code snippet updates cosmos/ibc-go
2 participants
@damiannolan @crodriguezvega