Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

genesis coins must be sorted #794

Closed
ebuchman opened this issue Apr 5, 2018 · 2 comments
Closed

genesis coins must be sorted #794

ebuchman opened this issue Apr 5, 2018 · 2 comments
Labels
C:Types T:Bug

Comments

@ebuchman
Copy link
Member

ebuchman commented Apr 5, 2018

There was a bug (#787) because we weren't sorting genesis coins.

There's a fix in #793, but I find it precarious.

How can we better ensure that coins are always sorted ?

Ideally it happens automatically by the account mapper or something the first time we set the account.
@cwgoes cwgoes added this to the 1.0 Code Freeze milestone Apr 27, 2018
@zramsay zramsay removed the basecoin label May 18, 2018
@cwgoes
Copy link
Contributor

cwgoes commented Jun 16, 2018

Possibly we could refactor sdk.Coins so ordering isn't applicable, see #1277 (comment).

@ebuchman ebuchman added the T:Bug label Jun 20, 2018
@jackzampolin jackzampolin removed this from the 1.0 Code Freeze milestone Oct 12, 2018
@jackzampolin
Copy link
Member

Closing as done per @cwgoes. Yell at me if I'm wrong.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
C:Types T:Bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
6 participants
@ebuchman @alexanderbez @jackzampolin @zramsay @rigelrozanski @cwgoes