Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Consistent use of Plus vs Add etc. #2360

Closed
rigelrozanski opened this issue Sep 20, 2018 · 2 comments · Fixed by #3679
Closed

Consistent use of Plus vs Add etc. #2360

rigelrozanski opened this issue Sep 20, 2018 · 2 comments · Fixed by #3679
Assignees
@rigelrozanski
Labels
good first issue T: API Breaking Breaking changes that impact APIs and the SDK only (not state machine).

Comments

@rigelrozanski
Copy link
Contributor

Relevant for Coins, DecCoins, Decimal, Int etc. libraries in the SDK

Possible inconsistencies to verify:
Plus vs. Add
Minus vs. Sub
Div vs. Quo
Times vs. Mul

My preference is the latter of each of these v/s
@alexanderbez
Copy link
Contributor

++

@rigelrozanski rigelrozanski added the T: API Breaking Breaking changes that impact APIs and the SDK only (not state machine). label Jan 30, 2019
@rigelrozanski
Copy link
Contributor Author

As a part of this I think we should make consistent MulRaw and MulInt64 between Int and Dec again the latter is my preference

@rigelrozanski rigelrozanski self-assigned this Feb 19, 2019
@rigelrozanski rigelrozanski mentioned this issue Feb 19, 2019
Merged
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@rigelrozanski rigelrozanski

Labels
good first issue T: API Breaking Breaking changes that impact APIs and the SDK only (not state machine).
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

R4R: Consistent Operators cosmos/cosmos-sdk
3 participants
@alexanderbez @ValarDragon @rigelrozanski