Fix export segfault #2128
Fix export segfault #2128
Conversation
mslipper
requested review from
cwgoes,
ebuchman and
rigelrozanski
as code owners
There was a problem hiding this comment.
utACK -- looks great @mslipper, just left a remark or two 👍
server/export.go
Outdated
| } | ||
|
|
||
| if emptyState { | ||
| fmt.Println("WARNING: State is not initialized. Returning genesis.json.") |
There was a problem hiding this comment.
Returning genesis file. I think might sound a bit better?
| @@ -43,3 +60,12 @@ func ExportCmd(ctx *Context, cdc *wire.Codec, appExporter AppExporter) *cobra.Co | |||
| }, | |||
| } | |||
| } | |||
|
|
|||
| func isEmptyState(home string) (bool, error) { | |||
There was a problem hiding this comment.
@ValarDragon is this sanity check enough or is there a more direct method we can perform via some attempted state lookup?
There was a problem hiding this comment.
Seems fine to me since we ensure all file writes persist to disk. I think we can merge this, and then write an issue to query state directly later. (#postlaunch concern)
server/export_test.go
Outdated
| os.Stdout = old | ||
| out := <-outC | ||
| require.Contains(t, out, "WARNING: State is not initialized") | ||
| require.Contains(t, out, "consensus_params") |
There was a problem hiding this comment.
Should we check for other top level keys?
|
Also let's merge |
Codecov Report
@@ Coverage Diff @@
## develop #2128 +/- ##
===========================================
+ Coverage 63.85% 63.91% +0.05%
===========================================
Files 134 134
Lines 8175 8194 +19
===========================================
+ Hits 5220 5237 +17
+ Misses 2605 2604 -1
- Partials 350 353 +3 |
Closes #1834
docs/)PENDING.mdwith issue #Files changedin the github PR explorerFor Admin Use: