Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Bug]: delete key error if key not found in list #18561

Closed
1 task done
JulianToledano opened this issue Nov 27, 2023 · 0 comments · Fixed by #18562
Closed
1 task done

[Bug]: delete key error if key not found in list #18561

JulianToledano opened this issue Nov 27, 2023 · 0 comments · Fixed by #18562
Labels
C:Keys Keybase, KMS and HSMs S:zondax Squad: Zondax T:Bug

Comments

@JulianToledano
Copy link
Contributor

Is there an existing issue for this?

  • I have searched the existing issues

What happened?

If you provide a list of keys to the keys delete command, it will stop and fail if one of those keys is not found.

Let's prompt an error when a key is not found and still delete the following ones.

Cosmos SDK Version

main

How to reproduce?

simd keys add two
simd keys add three
simd keys add four

simd keys delete one two three four

one.info: key not found [cosmos/cosmos-sdk/crypto/keyring/keyring.go:538]
@JulianToledano JulianToledano added T:Bug C:Keys Keybase, KMS and HSMs labels Nov 27, 2023
@github-project-automation github-project-automation bot moved this to 👀 To Do in Cosmos-SDK Legacy Nov 27, 2023
@JulianToledano JulianToledano mentioned this issue Nov 27, 2023
Merged
20 tasks
@JulianToledano JulianToledano linked a pull request Nov 27, 2023 that will close this issue
fix(client/keys): don't return when key not found in keys delete #18562
Merged
20 tasks
@github-project-automation github-project-automation bot moved this from 👀 To Do to 🥳 Done in Cosmos-SDK Legacy Nov 27, 2023
@educlerici-zondax educlerici-zondax added the S:zondax Squad: Zondax label Nov 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
C:Keys Keybase, KMS and HSMs S:zondax Squad: Zondax T:Bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(client/keys): don't return when key not found in keys delete cosmos/cosmos-sdk
2 participants
@JulianToledano @educlerici-zondax