Adds unit tests

Author: cosmo0

TODO.md

@@ -2,7 +2,6 @@
 
 ## DAT check
 
-* unit tests for RebuildGame
 * Have a progress bar for the steps and a progress bar for the items in the step
 
 ## Other

src/ArcadeManager.Core.Tests/Services/DatCheckerTests.cs

@@ -8,6 +8,7 @@
 using ArcadeManager.Core.Infrastructure.Interfaces;
 using ArcadeManager.Core.Actions;
 using ArcadeManager.Core.Models.Zip;
+using FluentAssertions.Extensions;
 
 namespace ArcadeManager.Core.Tests.Services;
 
@@ -216,4 +217,68 @@ public void Cleanup_removes_excess_files()
 
         zipFiles.Should().HaveCount(2);
     }
+
+    [Fact]
+    public async Task Rom_is_rebuilt_crc()
+    {
+        // arrange: arguments
+        var args = new RomsActionCheckDat { Speed = "fast" };
+
+        // arrange: found files matching the game files in the romset
+        var foundFiles = new ReadOnlyGameRomFileList([
+            new ReadOnlyGameRomFile("rom1.zip", "romset", "file1.a", "", 123, "abc", ""),
+            new ReadOnlyGameRomFile("rom1.zip", "romset", "file2.a", "", 123, "def", ""),
+            new ReadOnlyGameRomFile("rom2.zip", "romset", "file3.a", "", 123, "ghi", "")
+        ]);
+
+        // arrange: expected files in the game
+        var gameFiles = new GameRomFilesList() {
+            new GameRomFile { Name = "file1.a", Size = 123, Crc = "abc" },
+            new GameRomFile { Name = "file2.a", Size = 123, Crc = "def" },
+            new GameRomFile { Name = "file3.a", Size = 123, Crc = "ghi" }
+        };
+
+        // arrange: assume file replace works
+        A.CallTo(() => fs.ReplaceZipFile(A<ZipFile>._, A<ZipFile>._, A<IGameRomFile>._, A<IGameRomFile>._))
+            .Returns(true);
+
+        // act
+        await sut.RebuildGame("rom.zip", foundFiles, gameFiles, args);
+
+        // assert
+        A.CallTo(() => fs.ReplaceZipFile(A<ZipFile>._, A<ZipFile>._, A<IGameRomFile>._, A<IGameRomFile>._))
+            .MustHaveHappened(3, Times.Exactly);
+    }
+    
+    [Fact]
+    public async Task Rom_is_rebuilt_sha1()
+    {
+        // arrange
+        var args = new RomsActionCheckDat { Speed = "slow" };
+
+        // arrange: found files in the romset
+        var foundFiles = new ReadOnlyGameRomFileList([
+            new ReadOnlyGameRomFile("rom1.zip", "romset", "file1.a", "", 123, "abc", "1"),
+            new ReadOnlyGameRomFile("rom1.zip", "romset", "file2.a", "", 123, "def", "2"),
+            new ReadOnlyGameRomFile("rom2.zip", "romset", "file3.a", "", 123, "ghi", "3")
+        ]);
+
+        // arrange: expected files in the game
+        var gameFiles = new GameRomFilesList() {
+            new GameRomFile { Name = "file1.a", Size = 123, Crc = "abc", Sha1 = "1" },
+            new GameRomFile { Name = "file2.a", Size = 123, Crc = "def", Sha1 = "2" },
+            new GameRomFile { Name = "file3.a", Size = 123, Crc = "ghi", Sha1 = "3" }
+        };
+
+        // arrange: assume file replace works
+        A.CallTo(() => fs.ReplaceZipFile(A<ZipFile>._, A<ZipFile>._, A<IGameRomFile>._, A<IGameRomFile>._))
+            .Returns(true);
+
+        // act
+        await sut.RebuildGame("rom.zip", foundFiles, gameFiles, args);
+
+        // assert
+        A.CallTo(() => fs.ReplaceZipFile(A<ZipFile>._, A<ZipFile>._, A<IGameRomFile>._, A<IGameRomFile>._))
+            .MustHaveHappened(3, Times.Exactly);
+    }
 }

src/ArcadeManager.Core/Services/DatChecker.cs

@@ -333,7 +333,7 @@ public async Task RebuildGame(string gameFileFixed, ReadOnlyGameRomFileList foun
 
                 if (!await fs.ReplaceZipFile(sourceZip, targetZip, sourceFile, romFile))
                 {
-                    Console.WriteLine($"warning: did not replace {sourceFile.Name} from {sourceZip.FilePath} to {targetZip.FilePath}");
+                    Console.WriteLine($"warning: did not replace {sourceFile.Name} from {sourceZip?.FilePath} to {targetZip?.FilePath}");
                 }
             }
         }