feat: [M3-6945] – Support VPC and Subnet events (linode#9530)

Author: dwiley-akamai

packages/api-v4/.changeset/pr-9530-added-1692198648058.md

@@ -0,0 +1,5 @@
+---
+"@linode/api-v4": Added
+---
+
+VPC- and Subnet-related event types ([#9530](https://github.com/linode/manager/pull/9530))

packages/api-v4/src/account/types.ts

@@ -239,8 +239,8 @@ export interface Entity {
 }
 
 export type EventAction =
-  | 'account_update'
   | 'account_settings_update'
+  | 'account_update'
   | 'backups_cancel'
   | 'backups_enable'
   | 'backups_restore'
@@ -249,18 +249,24 @@ export type EventAction =
   | 'community_question_reply'
   | 'credit_card_updated'
   | 'database_low_disk_space_remaining'
+  | 'database_backup_restore'
+  | 'database_create'
+  | 'database_credentials_reset'
+  | 'database_delete'
+  | 'database_update_failed'
+  | 'database_update'
   | 'disk_create'
-  | 'disk_update'
   | 'disk_delete'
   | 'disk_duplicate'
   | 'disk_imagize'
   | 'disk_resize'
+  | 'disk_update'
   | 'domain_create'
-  | 'domain_update'
   | 'domain_delete'
   | 'domain_record_create'
-  | 'domain_record_updated'
   | 'domain_record_delete'
+  | 'domain_record_updated'
+  | 'domain_update'
   | 'entity_transfer_accept'
   | 'entity_transfer_cancel'
   | 'entity_transfer_create'
@@ -274,73 +280,73 @@ export type EventAction =
   | 'firewall_enable'
   | 'firewall_update'
   | 'host_reboot'
+  | 'image_delete'
   | 'image_update'
   | 'image_upload'
-  | 'image_delete'
   | 'lassie_reboot'
   | 'linode_addip'
   | 'linode_boot'
   | 'linode_clone'
+  | 'linode_config_create'
+  | 'linode_config_delete'
+  | 'linode_config_update'
   | 'linode_create'
-  | 'linode_update'
   | 'linode_delete'
   | 'linode_deleteip'
-  | 'linode_migrate'
-  | 'linode_reboot'
-  | 'linode_resize'
-  | 'linode_resize_create'
   | 'linode_migrate_datacenter_create'
   | 'linode_migrate_datacenter'
-  | 'linode_mutate'
+  | 'linode_migrate'
   | 'linode_mutate_create'
+  | 'linode_mutate'
+  | 'linode_reboot'
   | 'linode_rebuild'
+  | 'linode_resize_create'
+  | 'linode_resize'
   | 'linode_shutdown'
   | 'linode_snapshot'
-  | 'linode_config_create'
-  | 'linode_config_update'
-  | 'linode_config_delete'
+  | 'linode_update'
   | 'lke_node_create'
   | 'longviewclient_create'
   | 'longviewclient_delete'
   | 'longviewclient_update'
   | 'nodebalancer_config_create'
-  | 'nodebalancer_config_update'
   | 'nodebalancer_config_delete'
+  | 'nodebalancer_config_update'
   | 'nodebalancer_create'
-  | 'nodebalancer_update'
   | 'nodebalancer_delete'
+  | 'nodebalancer_update'
   | 'password_reset'
   | 'profile_update'
   | 'stackscript_create'
-  | 'stackscript_update'
   | 'stackscript_delete'
   | 'stackscript_publicize'
   | 'stackscript_revise'
-  | 'tfa_enabled'
+  | 'stackscript_update'
+  | 'subnet_create'
+  | 'subnet_delete'
+  | 'subnet_update'
   | 'tfa_disabled'
+  | 'tfa_enabled'
   | 'ticket_attachment_upload'
   | 'ticket_update'
+  | 'token_create'
+  | 'token_delete'
+  | 'token_update'
   | 'user_ssh_key_add'
-  | 'user_ssh_key_update'
   | 'user_ssh_key_delete'
+  | 'user_ssh_key_update'
+  | 'volume_attach'
+  | 'volume_clone'
   | 'volume_create'
-  | 'volume_update'
   | 'volume_delete'
   | 'volume_detach'
-  | 'volume_attach'
-  | 'volume_resize'
-  | 'volume_clone'
   | 'volume_migrate_scheduled'
   | 'volume_migrate'
-  | 'database_create'
-  | 'database_delete'
-  | 'database_update'
-  | 'database_update_failed'
-  | 'database_backup_restore'
-  | 'database_credentials_reset'
-  | 'token_create'
-  | 'token_update'
-  | 'token_delete';
+  | 'volume_resize'
+  | 'volume_update'
+  | 'vpc_create'
+  | 'vpc_delete'
+  | 'vpc_update';
 
 export type EventStatus =
   | 'scheduled'

packages/manager/.changeset/pr-9530-added-1691618959800.md

@@ -0,0 +1,5 @@
+---
+"@linode/manager": Added
+---
+
+Support for VPC and subnet events ([#9530](https://github.com/linode/manager/pull/9530))

packages/manager/cypress/e2e/core/notificationsAndEvents/events.spec.ts

@@ -6,29 +6,28 @@ import { containsClick, getClick } from 'support/helpers';
 import { apiMatcher } from 'support/util/intercepts';
 
 const eventActions: RecPartial<EventAction>[] = [
-  'backups_enable',
   'backups_cancel',
+  'backups_enable',
   'backups_restore',
-  'community_question_reply',
   'community_like',
+  'community_question_reply',
   'disk_create',
   'disk_delete',
-  'disk_update',
   'disk_duplicate',
-  // 'disk_imagize',
   'disk_resize',
+  'disk_update',
   'entity_transfer_accept',
   'entity_transfer_cancel',
   'entity_transfer_create',
   'entity_transfer_fail',
   'entity_transfer_stale',
   'firewall_create',
   'firewall_delete',
+  'firewall_device_add',
+  'firewall_device_remove',
   'firewall_disable',
   'firewall_enable',
   'firewall_update',
-  'firewall_device_add',
-  'firewall_device_remove',
   'host_reboot',
   'image_delete',
   'image_update',
@@ -37,9 +36,11 @@ const eventActions: RecPartial<EventAction>[] = [
   'linode_addip',
   'linode_boot',
   'linode_clone',
+  'linode_config_create',
+  'linode_config_delete',
+  'linode_config_update',
   'linode_create',
   'linode_delete',
-  'linode_update',
   'linode_deleteip',
   'linode_migrate',
   'linode_migrate_datacenter',
@@ -49,38 +50,37 @@ const eventActions: RecPartial<EventAction>[] = [
   'linode_resize',
   'linode_shutdown',
   'linode_snapshot',
-  'linode_config_create',
-  'linode_config_delete',
-  'linode_config_update',
+  'linode_update',
   'lke_node_create',
   'longviewclient_create',
   'longviewclient_delete',
   'longviewclient_update',
-  'nodebalancer_create',
-  'nodebalancer_delete',
-  'nodebalancer_update',
   'nodebalancer_config_create',
   'nodebalancer_config_delete',
   'nodebalancer_config_update',
+  'nodebalancer_create',
+  'nodebalancer_delete',
+  'nodebalancer_update',
   'stackscript_create',
   'stackscript_delete',
-  'stackscript_update',
   'stackscript_publicize',
   'stackscript_revise',
+  'stackscript_update',
+  'subnet_create',
+  'subnet_delete',
+  'subnet_update',
   'tfa_disabled',
   'tfa_enabled',
-  'ticket_attachment_upload',
   'user_ssh_key_add',
   'user_ssh_key_delete',
   'user_ssh_key_update',
   'volume_clone',
   'volume_create',
-  'volume_update',
   'volume_detach',
   'volume_resize',
-  'account_update',
-  'account_settings_update',
-  'credit_card_updated',
+  'vpc_create',
+  'vpc_delete',
+  'vpc_update',
   // 'linode_migrate_datacenter_create',
   // 'linode_mutate_create',
   // 'linode_resize_create',

packages/manager/cypress/e2e/core/vpc/vpc-details-page.spec.ts

@@ -44,7 +44,7 @@ describe('VPC details page', () => {
     mockUpdateVPC(mockVPC.id, mockVPCUpdated).as('updateVPC');
     mockDeleteVPC(mockVPC.id).as('deleteVPC');
 
-    cy.visitWithLogin(`/vpc/${mockVPC.id}`);
+    cy.visitWithLogin(`/vpcs/${mockVPC.id}`);
     cy.wait(['@getFeatureFlags', '@getClientStream', '@getVPC']);
 
     // Confirm that VPC details are displayed.
@@ -112,7 +112,7 @@ describe('VPC details page', () => {
     cy.wait(['@deleteVPC', '@getVPCs']);
 
     // Confirm that user is redirected to VPC landing page.
-    cy.url().should('endWith', '/vpc');
+    cy.url().should('endWith', '/vpcs');
     cy.findByText('Create a private and isolated network.');
   });
 });

packages/manager/cypress/e2e/core/vpc/vpc-landing-page.spec.ts

@@ -7,7 +7,7 @@ import {
   mockGetVPCs,
   mockDeleteVPC,
   mockUpdateVPC,
-} from 'support/intercepts/vpc';
+} from 'support/intercepts/vpcs';
 import { vpcFactory } from '@src/factories';
 import { ui } from 'support/ui';
 import { randomLabel, randomPhrase } from 'support/util/random';
@@ -26,7 +26,7 @@ describe('VPC landing page', () => {
     mockGetFeatureFlagClientstream().as('getClientStream');
     mockGetVPCs(mockVPCs).as('getVPCs');
 
-    cy.visitWithLogin('/vpc');
+    cy.visitWithLogin('/vpcs');
     cy.wait(['@getFeatureFlags', '@getClientStream', '@getVPCs']);
 
     // Confirm each VPC is listed with expected data.
@@ -61,7 +61,7 @@ describe('VPC landing page', () => {
     mockGetFeatureFlagClientstream().as('getClientStream');
     mockGetVPCs([]).as('getVPCs');
 
-    cy.visitWithLogin('/vpc');
+    cy.visitWithLogin('/vpcs');
     cy.wait(['@getFeatureFlags', '@getClientStream', '@getVPCs']);
 
     // Confirm that empty state is shown and that each section is present.
@@ -79,7 +79,7 @@ describe('VPC landing page', () => {
       .should('be.enabled')
       .click();
 
-    cy.url().should('endWith', '/vpc/create');
+    cy.url().should('endWith', '/vpcs/create');
   });
 
   /*
@@ -106,7 +106,7 @@ describe('VPC landing page', () => {
     mockGetVPCs([mockVPC]).as('getVPCs');
     mockUpdateVPC(mockVPC.id, mockUpdatedVPC).as('updateVPC');
 
-    cy.visitWithLogin('/vpc');
+    cy.visitWithLogin('/vpcs');
     cy.wait(['@getFeatureFlags', '@getClientStream', '@getVPCs']);
 
     // Find mocked VPC and click its "Edit" button.
@@ -194,7 +194,7 @@ describe('VPC landing page', () => {
     mockGetVPCs(mockVPCs).as('getVPCs');
     mockDeleteVPC(mockVPCs[0].id).as('deleteVPC');
 
-    cy.visitWithLogin('/vpc');
+    cy.visitWithLogin('/vpcs');
     cy.wait(['@getFeatureFlags', '@getClientStream', '@getVPCs']);
 
     // Delete first VPC.
@@ -283,7 +283,7 @@ describe('VPC landing page', () => {
     }).as('getFeatureFlags');
     mockGetFeatureFlagClientstream().as('getClientStream');
 
-    cy.visitWithLogin('/vpc');
+    cy.visitWithLogin('/vpcs');
     cy.wait(['@getFeatureFlags', '@getClientStream']);
 
     cy.findByText('Not Found').should('be.visible');

packages/manager/cypress/e2e/core/vpc/vpc-navigation.spec.ts

@@ -26,7 +26,7 @@ describe('VPC navigation', () => {
 
     ui.nav.findItemByTitle('VPC').should('be.visible').click();
 
-    cy.url().should('endWith', '/vpc');
+    cy.url().should('endWith', '/vpcs');
   });
 
   /*

packages/manager/src/GoTo.tsx

@@ -93,7 +93,7 @@ const GoTo = (props: Props) => {
       {
         display: 'VPC',
         hide: !flags.vpc,
-        href: '/vpc',
+        href: '/vpcs',
       },
       {
         display: 'NodeBalancers',

packages/manager/src/MainContent.tsx

@@ -358,7 +358,9 @@ const MainContent = (props: CombinedProps) => {
                             {flags.selfServeBetas ? (
                               <Route component={BetaRoutes} path="/betas" />
                             ) : null}
-                            {flags.vpc && <Route component={VPC} path="/vpc" />}
+                            {flags.vpc && (
+                              <Route component={VPC} path="/vpcs" />
+                            )}
                             <Redirect exact from="/" to={defaultRoot} />
                             {/** We don't want to break any bookmarks. This can probably be removed eventually. */}
                             <Redirect from="/dashboard" to={defaultRoot} />

packages/manager/src/components/PrimaryNav/PrimaryNav.tsx

@@ -178,7 +178,7 @@ export const PrimaryNav = (props: Props) => {
         {
           display: 'VPC',
           hide: !flags.vpc,
-          href: '/vpc',
+          href: '/vpcs',
           icon: <VPC />,
           isBeta: true,
         },

packages/manager/src/features/Events/EventRow.tsx

@@ -54,7 +54,9 @@ export interface RowProps {
     | 'linode'
     | 'nodebalancer'
     | 'stackscript'
-    | 'volume';
+    | 'subnet'
+    | 'volume'
+    | 'vpc';
   username: null | string;
 }