Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for iam roles for service accounts in AWS #1797

Closed
adamjohnson01 opened this issue Nov 8, 2019 · 2 comments · Fixed by #1803
Closed

Add support for iam roles for service accounts in AWS #1797

adamjohnson01 opened this issue Nov 8, 2019 · 2 comments · Fixed by #1803

Comments

@adamjohnson01
Copy link
Contributor

Due to this issue in the aws sdk, it is not possible to authenticate using iam roles for service accounts in AWS EKS.

This is because session.New is being used.

s3Client := s3.New(session.New(s3Config))

session.New is deprecated and requires the AWS_SDK_LOAD_CONFIG environment variable to be set in order to automatically call AssumeRoleWithWebIdentity.

I propose updating to use session.NewSession instead. I am happy to contribute this change.

@bboreham
Copy link
Contributor

bboreham commented Nov 8, 2019

Thanks for pointing this out. Please go ahead and make a PR if you are able.
Do we need to change this too?

return dynamodb.New(dynamoDBSession), nil

@adamjohnson01
Copy link
Contributor Author

Yes, that need to change as well.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants