firstly, I'm tired of the 0.0.0.0.0.0 crap, so juno's versionining system has been changed for the first time in three years. versions are now whatever I want them to be, and this one shall be called version 5.8.

Author: cooper

inc/channel/mine.pm

@@ -119,11 +119,14 @@ sub take_lower_time {
     delete $channel->{topic};
 
     # unset all channel modes
-    my $modestring = ($channel->mode_string_all(gv('SERVER')))[0];
+    my ($modestring, $servermodestring) = $channel->mode_string_all(gv('SERVER'));
     $modestring =~ s/\+/\-/;
     send_all($channel, ':'.gv('SERVER', 'name')." MODE $$channel{name} $modestring");
-    $channel->{modes} = {};
 
+    # hackery: use the server mode string to reset all modes.
+    # ($channel, $server, $source, $modestr, $force, $over_protocol)
+    $channel->handle_mode_string(gv('SERVER'), gv('SERVER'), $servermodestring, 1, 1);
+    
     notice_all($channel, 'channel properties reset');
     return $channel->{time}
 }

inc/connection.pm

@@ -292,7 +292,7 @@ sub done {
 
     if ($connection->{type}) {
         # share this quit with the children
-        server::mine::fire_command_all(quit => $connection, $reason) unless $connection->{type}->isa('server');
+        server::mine::fire_command_all(quit => $connection, $reason);
 
         # tell user.pm or server.pm that the connection is closed
         $connection->{type}->quit($reason)

inc/ircd.pm

@@ -10,7 +10,7 @@ use utils qw(conf lconf log2 fatal gv set);
 utils::ircd_LOAD();
 
 our @reloadable;
-my ($VERSION, %global) = '5.0.0.6';
+my ($VERSION, %global) = '5.8';
 
 sub start {
 

mod/core_scommands.pm

@@ -318,27 +318,21 @@ sub sjoin {
     my ($server, $data, $user, $chname, $time) = @_;
     my $channel = channel::lookup_by_name($chname);
 
-    # the channel exists, so just join
-    if ($channel) {
-        return if $channel->has_user($user);
-
-        # take the lower time
-        $channel->channel::mine::take_lower_time($time);
-
-    }
-
     # channel doesn't exist; make a new one
-    else {
+    if (!$channel) {
         $channel = channel->new({
             name => $chname,
             time => $time
         });
     }
 
-    $channel->cjoin($user, $time);
+    # take lower time if necessary, and add the user to the channel.
+    $channel->channel::mine::take_lower_time($time);
+    $channel->cjoin($user, $time) unless $channel->has_user($user);
 
-    # for each user in the channel
+    # for each user in the channel, send a JOIN message.
     $channel->channel::mine::send_all(q(:).$user->full." JOIN $$channel{name}");
+    
 }
 
 # add user flags
@@ -547,6 +541,7 @@ sub skill {
 
     # we ignore any non-local users
     $tuser->{conn}->done("Killed: $reason [$$user{nick}]") if $tuser->is_local;
+
 }
 
 $mod

mod/core_ucommands.pm

@@ -476,12 +476,14 @@ sub cjoin {
             ($ur, $sr) = $channel->handle_mode_string($me, $me, $str, 1, 1);
         }
 
+
+
         # tell servers that the user joined and the automatic modes were set
         server::mine::fire_command_all(sjoin => $user, $channel, $time);
         server::mine::fire_command_all(cmode => $me, $channel, $time, $me->{sid}, $sr) if $sr;
 
         $channel->channel::mine::cjoin($user, $time, 1)
-    }
+        
 }
 
 sub names {