Skip to content
This repository has been archived by the owner on Mar 9, 2022. It is now read-only.

Consolidate resolver package with containerd. #723

Closed
Random-Liu opened this issue Apr 6, 2018 · 1 comment · Fixed by #838
Closed

Consolidate resolver package with containerd. #723

Random-Liu opened this issue Apr 6, 2018 · 1 comment · Fixed by #838
Assignees
@abhi @Random-Liu
Milestone
next-candidate

Comments

@Random-Liu
Copy link
Member

Random-Liu commented Apr 6, 2018 •
edited
Loading

Today, to support registry mirror in cri, we copied containerd docker resolver package https://github.com/containerd/containerd/blob/master/remotes/docker/resolver.go, and maintained it at https://github.com/containerd/cri/blob/master/pkg/containerd/resolver/resolver.go.

This introduced a lot of code duplication. And we have to keep porting fix to our own resolver package, e.g. #722.

We should:

  • Either move the registry mirror logic into containerd (may need a more comprehensive proposal).
  • Or at least make most code in docker/resolver a library that we can reuse in cri.

@abhi
@Random-Liu Random-Liu mentioned this issue Apr 9, 2018
Merged
@Random-Liu Random-Liu added this to the next-candidate milestone Apr 13, 2018
@Random-Liu Random-Liu modified the milestones: next-candidate, v1.11 May 2, 2018
@Random-Liu Random-Liu mentioned this issue May 31, 2018
Merged
@Random-Liu
Copy link
Member Author

I don't think we can finish this issue this release. Move to next.

@Random-Liu Random-Liu modified the milestones: v1.11, next-candidate Jun 25, 2018
@Random-Liu Random-Liu self-assigned this Jul 9, 2018
@Random-Liu Random-Liu mentioned this issue Jul 9, 2018
Merged
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@abhi abhi

@Random-Liu Random-Liu

Labels
None yet
Projects
None yet
Milestone
next-candidate
Development

Successfully merging a pull request may close this issue.

Add auth config Random-Liu/cri-containerd
2 participants
@abhi @Random-Liu