From bbf2f9841051dc529449cb5b6c737a6ba1590573 Mon Sep 17 00:00:00 2001 From: Adam Simon Date: Wed, 14 Feb 2024 15:02:44 +0100 Subject: [PATCH] Improve naming --- src/ConfigCatClient/Evaluation/EvaluateLogHelper.cs | 12 ++++++------ src/ConfigCatClient/Evaluation/RolloutEvaluator.cs | 4 ++-- 2 files changed, 8 insertions(+), 8 deletions(-) diff --git a/src/ConfigCatClient/Evaluation/EvaluateLogHelper.cs b/src/ConfigCatClient/Evaluation/EvaluateLogHelper.cs index cffff0c0..a1ee0819 100644 --- a/src/ConfigCatClient/Evaluation/EvaluateLogHelper.cs +++ b/src/ConfigCatClient/Evaluation/EvaluateLogHelper.cs @@ -14,11 +14,6 @@ internal static class EvaluateLogHelper internal const int StringListMaxLength = 10; - public static IndentedTextBuilder AppendEvaluationResult(this IndentedTextBuilder builder, bool result) - { - return builder.Append(result ? "true" : "false"); - } - private static IndentedTextBuilder AppendUserCondition(this IndentedTextBuilder builder, string? comparisonAttribute, UserComparator comparator, object? comparisonValue) { return builder.Append($"User.{comparisonAttribute} {comparator.ToDisplayText()} '{comparisonValue ?? InvalidValuePlaceholder}'"); @@ -148,9 +143,14 @@ public static IndentedTextBuilder AppendSegmentCondition(this IndentedTextBuilde return builder.Append($"User {comparator.ToDisplayText()} '{segmentName}'"); } + public static IndentedTextBuilder AppendConditionResult(this IndentedTextBuilder builder, bool result) + { + return builder.Append(result ? "true" : "false"); + } + public static IndentedTextBuilder AppendConditionConsequence(this IndentedTextBuilder builder, bool result) { - builder.Append(" => ").AppendEvaluationResult(result); + builder.Append(" => ").AppendConditionResult(result); return result ? builder : builder.Append(", skipping the remaining AND conditions"); } diff --git a/src/ConfigCatClient/Evaluation/RolloutEvaluator.cs b/src/ConfigCatClient/Evaluation/RolloutEvaluator.cs index 41d4f549..0f4f5bf9 100644 --- a/src/ConfigCatClient/Evaluation/RolloutEvaluator.cs +++ b/src/ConfigCatClient/Evaluation/RolloutEvaluator.cs @@ -765,7 +765,7 @@ private bool EvaluatePrerequisiteFlagCondition(PrerequisiteFlagCondition conditi .NewLine().Append($"Prerequisite flag evaluation result: '{prerequisiteFlagValue}'.") .NewLine("Condition (") .AppendPrerequisiteFlagCondition(condition, context.Settings) - .Append(") evaluates to ").AppendEvaluationResult(result).Append(".") + .Append(") evaluates to ").AppendConditionResult(result).Append(".") .DecreaseIndent() .NewLine(")"); @@ -823,7 +823,7 @@ private bool EvaluateSegmentCondition(SegmentCondition condition, ref EvaluateCo logBuilder.NewLine("Condition (").AppendSegmentCondition(condition).Append(")"); (error is null - ? logBuilder.Append(" evaluates to ").AppendEvaluationResult(result) + ? logBuilder.Append(" evaluates to ").AppendConditionResult(result) : logBuilder.Append(" failed to evaluate")) .Append(".");