Skip to content
This repository was archived by the owner on May 23, 2022. It is now read-only.

- The validation section could be more in depth #1

Open
reindert-vetter opened this issue Feb 7, 2021 · 6 comments
Open

- The validation section could be more in depth #1

reindert-vetter opened this issue Feb 7, 2021 · 6 comments
Assignees

Comments

@reindert-vetter
Copy link
Contributor

  • The validation section could be more in depth
    • E.g. the "unique" key, if you open a issue I could help adding more validations, implementing TDD in those new features

Originally posted by @rafaelbreno in confetti-framework/confetti#97 (comment)

@reindert-vetter
Copy link
Contributor Author

reindert-vetter commented Feb 7, 2021

@rafaelbreno you can use this issue. Please commit with prefix #1
Thanks for TDD. With this repository I would indeed like to have 100% test coverage.

@rafaelbreno
Copy link

I'll be forking and creating a branch to test and separate everything, if you can, could you assign this to me? Will help maintain the track of the notifications.

@rafaelbreno
Copy link

Add regex validation

@rafaelbreno
Copy link

Add in_array validation.

Remembering, I'm solving this issue in this fork

@reindert-vetter
Copy link
Contributor Author

@rafaelbreno Look good! You may want to create a pull request after this and continue in a new branch. Then I can already look at it and write documentation.

@rafaelbreno
Copy link

@reindert-vetter I'm going to PR what I've for now.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants