Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upstream replied for skipped test(s) #79

Open
1 task done
step21 opened this issue Oct 18, 2021 · 6 comments
Open
1 task done

Upstream replied for skipped test(s) #79

step21 opened this issue Oct 18, 2021 · 6 comments

Comments

@step21
Copy link
Contributor

step21 commented Oct 18, 2021

FYI scikit-image/scikit-image#4775

@jakirkham
Copy link
Member

Sounds like the next step is try running all tests here again and see what fails?

@step21
Copy link
Contributor Author

step21 commented Oct 18, 2021

Yeah I guess. I am super busy the next two weeks with finishing my thesis, so maybe someone else could open a PR?

@hmaarrfk
Copy link
Contributor

Does conda-forge really care about releasing this patch?

I am a core dev at scikit-image, but ultimately, I feel like issues like this should be used as motivation for upstream developers to cut new release.

Unfortunately, build infrastructure is hard to maintain.

So if you cut 2 releases a year, then you can't be expected that it will always be a smooth process.

I would love to be able to cut a 0.18.x release, but I haven't had time for the last month or so.

My point is more that, i'm unsure if you, @step21, want us to release a patch that makes your code with scikit-image "unreleased" version 0.18. It will make your code very fragile to a specific build made by conda-forge, and will not be usable by those that follow upstream releases.

@step21
Copy link
Contributor Author

step21 commented Oct 19, 2021

@hmaarrfk Others are more involved with scikit-image, but generally - no, I don't think we want a special release. It has been like this for a while, so a bit more won't hurt anything. We could run tests again to see which errors still happen - then you or whoever from scikit-image can cut a new release whenever you get to it. (or not if you cannot find the error)

@hmaarrfk
Copy link
Contributor

If you want to just the CIs then you can make a merge request labelled as "draft" or "WIP". You definitely don't need permissions to do this.

Patching isn't always easy (especially since alot of cleanup has happened in scikit-image recently).

Are you interested in running tests on a particular platform? Or x86 64bit?

@step21
Copy link
Contributor Author

step21 commented Oct 19, 2021

Yeah, I know that I can do a PR. I just wanted to bring it to the rest of the conda-forge teams attention, as I have zero time atm. In the recipe file, it is noted on which combination the test failed, f.e.e python 3.8 macos. But if I do a PR I'd probably just run everything.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants