Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[request] abseil/latest #710

Closed
Samuel-Tyler opened this issue Jan 20, 2020 · 7 comments · Fixed by #801
Closed

[request] abseil/latest #710

Samuel-Tyler opened this issue Jan 20, 2020 · 7 comments · Fixed by #801

Comments

@Samuel-Tyler
Copy link

Package Details

Description Of The Library / Tool

Abseil is an open source collection of C++ libraries drawn from the most fundamental pieces of Google’s internal codebase. These libraries are the nuts-and-bolts that underpin almost everything Google runs. Bits and pieces of these APIs are embedded in most of our open source projects, and Abseil aims to bring them together into one comprehensive project. Abseil encompasses the most basic building blocks of Google’s codebase: code that is production-tested and will be fully maintained for years to come.

Note

Abseil makes updates frequently and supports a "live at head" mantra. Ideally the version would be frequently updated.

@uilianries
Copy link
Member

uilianries commented Jan 20, 2020

You can use https://github.com/bincrafters/conan-abseil as reference.

NOTE: tools.collect_libs is not a good, as the libraries order matters for static link. We had many problems using it in Abseil's recipe.

@Minimonium
Copy link
Contributor

@uilianries There is a problem with Abseil removing releases on the GitHub page from time to time. Some releases pointed from the Bincrafters repo do not exist anymore. How should it be solved in the context of the CCI?

@uilianries
Copy link
Member

Abseil removing releases on the GitHub page from time to time.

I didn't know about! We can mirror the source package to JFrog Bintray :)

@Croydon
Copy link
Contributor

Croydon commented Jan 28, 2020

There is a problem with Abseil removing releases on the GitHub page from time to time.

I feel like this is a huge anti-pattern. Do they explain somewhere why they are doing this?

@Croydon
Copy link
Contributor

Croydon commented Jan 28, 2020

In this specific case I wouldn't go for mirroring. When it is hosted on GitHub we can download the zip file of a specific git commit instead of a release zip

@Minimonium
Copy link
Contributor

Minimonium commented Jan 28, 2020

@Croydon No, I just realized that they have much fewer releases now than used by the Bincrafters' recipe.
Nice idea about the specific git commit link! Didn't know about it, thanks!

@uilianries
Copy link
Member

Yeah, I totally forgot about github commit

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants