fix: service in wrong namespace (#4)

Author: philwinder

.github/workflows/documentation.yaml

@@ -15,4 +15,4 @@ jobs:
         git-push: "true"
         config-file: .terraform-docs.yml
         output-file: README.md
-        output-method: replace
+        output-method: replace

.github/workflows/terraform.yaml

@@ -38,18 +38,18 @@ jobs:
           #### Terraform Initialization ⚙️\`${{ steps.init.outcome }}\`
           #### Terraform Validation 🤖${{ steps.validate.outputs.stdout }}
           #### Terraform Plan 📖\`${{ steps.plan.outcome }}\`
-          
+
           <details><summary>Show Plan</summary>
-          
+
           \`\`\`${process.env.PLAN}\`\`\`
-          
+
           </details>
-          
+
           *Pusher: @${{ github.actor }}, Action: \`${{ github.event_name }}\`, Working Directory: \`${{ env.tf_actions_working_dir }}\`, Workflow: \`${{ github.workflow }}\`*`;
-            
+
           github.issues.createComment({
             issue_number: context.issue.number,
             owner: context.repo.owner,
             repo: context.repo.repo,
             body: output
-          })
+          })

.gitignore

@@ -29,4 +29,4 @@ override.tf.json
 # example: *tfplan*
 .terraform/
 **/*.log
-**/*.hcl
+**/*.hcl

.header.md

@@ -22,11 +22,11 @@ KUBE_CONFIG_PATH=~/.kube/config terraform apply
 ### Stack Deletion
 
 ```bash
-KUBE_CONFIG_PATH=~/.kube/config terraform destroy 
+KUBE_CONFIG_PATH=~/.kube/config terraform destroy
 ```
 
 ## Known Issues
 
 - Why do you have to explicitly export the Kubernetes config?
 
-I found that hardcoding the kubeconfig led to [this terraform bug](https://github.com/terraform-aws-modules/terraform-aws-eks/issues/1234).
+I found that hardcoding the kubeconfig led to [this terraform bug](https://github.com/terraform-aws-modules/terraform-aws-eks/issues/1234).

.pre-commit-config.yaml

@@ -0,0 +1,24 @@
+repos:
+  - repo: https://github.com/pre-commit/pre-commit-hooks
+    rev: v3.4.0
+    hooks:
+      -   id: check-added-large-files
+      -   id: check-executables-have-shebangs
+      -   id: check-json
+      -   id: pretty-format-json
+      -   id: check-merge-conflict
+      -   id: check-symlinks
+      -   id: check-toml
+      -   id: check-vcs-permalinks
+      -   id: check-xml
+      -   id: check-yaml
+      -   id: destroyed-symlinks
+      -   id: detect-private-key
+      -   id: end-of-file-fixer
+      -   id: mixed-line-ending
+      -   id: sort-simple-yaml
+      -   id: trailing-whitespace
+  -   repo: https://github.com/Yelp/detect-secrets
+      rev: v1.1.0
+      hooks:
+      -   id: detect-secrets

.terraform-docs.yml

@@ -11,4 +11,4 @@ output:
   file: README.md
   mode: replace
   template: |-
-    {{ .Content }}
+    {{ .Content }}

.testfaster.yml

@@ -1,4 +1,4 @@
-name: Pachyderm + Minio
+name: Feast - Combinator Component
 base:
   kernel_image: quay.io/testfaster/ignite-kernel
   os_dockerfile: |-
@@ -54,4 +54,4 @@ launch:
       port: 31888
   homepage: |
     ## Follow the tutorial below
-    Click the buttons above.
+    Click the buttons above.

examples/testfaster/main.tf

@@ -1,18 +1,27 @@
+variable "namespace" {
+  description = "(Optional) The namespace to install into. Defaults to feast."
+  type        = string
+  default     = "feast"
+}
+
 module "feast" {
-  source = "combinator-ml/feast/k8s"
+  source    = "combinator-ml/feast/k8s"
+  namespace = var.namespace
 }
 
 resource "kubernetes_service" "jupyter" {
   metadata {
-    name = "testfaster-jupyter"
+    name      = "testfaster-jupyter"
+    namespace = var.namespace
   }
   spec {
     selector = {
       app = "feast-jupyter"
     }
     port {
-      port        = 31888
+      port        = 8888
       target_port = 8888
+      node_port   = 31888
     }
     type = "NodePort"
   }