Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: dates sent as ISO not DD-MM-YYYY #122

Merged
merged 8 commits into from
Feb 14, 2025
Merged

fix: dates sent as ISO not DD-MM-YYYY #122

merged 8 commits into from
Feb 14, 2025

Conversation

mamico
Copy link
Contributor

@mamico mamico commented Dec 6, 2024

dates should be sent in ISO format (the widget's default should be fine), not DD-MM-YYYY

@JeffersonBledsoe
Copy link
Member

@mamico This needs collective.volto.formsupport >= 3.1.4 (specifically collective/collective.volto.formsupport#34) to work right? What happens if the backend is less than this version?

@mamico
Copy link
Contributor Author

mamico commented Dec 6, 2024

@mamico This needs collective.volto.formsupport >= 3.1.4 (specifically collective/collective.volto.formsupport#34) to work right? What happens if the backend is less than this version?

In this case, I believe dates would be saved/sent in ISO format instead of DD/MM/YYYY format.

cekk added a commit to RedTurtle/design-comuni-plone-theme that referenced this pull request Dec 10, 2024
pnicolli pushed a commit to RedTurtle/design-comuni-plone-theme that referenced this pull request Dec 20, 2024
pnicolli pushed a commit to RedTurtle/design-comuni-plone-theme that referenced this pull request Dec 20, 2024
mamico added a commit to RedTurtle/design-comuni-plone-theme that referenced this pull request Jan 7, 2025
@JeffersonBledsoe
Copy link
Member

In this case, I believe dates would be saved/sent in ISO format instead of DD/MM/YYYY format.

@mamico This is a breaking change then, right? Otherwise, LGTM!

@mamico
Copy link
Contributor Author

mamico commented Feb 13, 2025

In this case, I believe dates would be saved/sent in ISO format instead of DD/MM/YYYY format.

@mamico This is a breaking change then, right? Otherwise, LGTM!

Not sure if we can call it breaking, but we can document the backend requirement in the README, as we've done for the others.

@mamico mamico changed the title fix: dates sent as ISO fix: dates sent as ISO not DD-MM-YYYY Feb 13, 2025
@mamico mamico requested a review from stevepiercy February 13, 2025 21:19
Copy link
Member

@stevepiercy stevepiercy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll push these commits. This will make it easier to read and maintain.

@stevepiercy
Copy link
Member

Here's how the changes I made will look.

Note

  • Since version v2.0.0 of this add-on, collective.volto.formsupport 2.0.0 or later and performing its upgrade steps is required.
  • Since version v2.1.2 of this add-on, Volto 14.2.0 or later is required.
  • Since version v3.0.0 of this add-on, Volto 16.0.0-alpha.38 or later is required.
  • Since version v3.11.0 of this add-on, collective.volto.formsupport 3.1.4 or later is required.

@giuliaghisini giuliaghisini merged commit 9c2ce02 into main Feb 14, 2025
@giuliaghisini giuliaghisini deleted the date_iso_format branch February 14, 2025 09:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants