exposing Rosetta types.Error in fetcher #98
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This is GREAT work @cindyxkuang! Looking forward to seeing this applied to the other endpointsin |
qiwu7
reviewed
Aug 13, 2020
|
Can we return a |
qiwu7
reviewed
Aug 13, 2020
qiwu7
reviewed
Aug 13, 2020
qiwu7
reviewed
Aug 13, 2020
qiwu7
previously approved these changes
Aug 13, 2020
signing signing plus small edit renaming res to fetcherErr
qiwu7
approved these changes
Aug 13, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes # .
Motivation
In order to allow consumers of the fetcher to parse errors upstream, we need to expose the Rosetta types.Errors being returned from our API calls.
Solution
Defined an ErrorRes struct that wraps both the Go error and Rosetta error being returned from API calls, and returning that from the fetcher instead.
Open questions