Add Reconciler Active/Inactive Concurrency Configuration #29
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Fix #28.
Solution
After some initial consideration to create a shared reconciliation goroutine pool (that always preferred active reconciliations to inactive reconciliations), I decided to stick with the 2 pool route and add a configuration to control the concurrency of each.
There are certain cases where you would not always want to prefer active reconciliations to inactive (for example, in the case where there are so many active reconciliations queued that you never do inactive reconciliations) so I opted for this dual configuration option en lieu of developing some complicated heuristic.