Initialize Reconciler with Previously Seen Addresses #26
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
When restarting the
Reconciler
, the record of previously seen accounts and the inactive reconciliation queue is discarded. Upon restart of the reconciler, there is no way to repopulate this record of previously seenAccountCurrency
. In therosetta-cli
, this can lead to inactive reconciliation not checking all accounts if reconciliation is restarted using the same datastore (common practice).Solution
Reconciler
to be instantiated with previously seen accounts.NewAccountSeen
to theReconciler.Handler
that is called whenever a new account is observed. This allows the client to store these new accounts persistently (to later provide for reconciler instantiation).