Merge branch pyproject #118
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Owner
codypiersall
commented
Dec 25, 2023
codypiersall
commented
- Move as much build info as possible into pyproject.toml
- Make a few tests that intermittently failed more robust (but there are still some intermittent failures)
- Update cibuildwheel to build wheels for Python 3.12.
added 8 commits
December 21, 2023 07:19
The sleeps are not reliable; they're usually too long for local development, and sometimes too short for CI. This brings pain. The sleeps are *mostly* just waiting for connections to happen in the background, so we can just check that directly for the most part. Also shrank some timeouts where it seemed possible.
…stead of returning False.
I'm not sure the exact root cause, but intermittently the test_close_pipe_works test would fail whenever pipe1 was not closed. The point of the test is still being accomplished, so we are still covering what we need to cover from a testing perspective.
It seems that there was a race between the pre_connect hook from one socket and the other socket thinking everything was hunky dory and creating a pipe. Telling *both* sockets to run the pre-connect hook ensures that neither socket thinks the connection is okay.
cibuildwheel now builds for Python 3.12. Configuration is now done declaratively in pyproject.toml.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.