Skip to content

CountdownCurtain: Add image #106

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
0pdd opened this issue Mar 23, 2019 · 1 comment
Closed

CountdownCurtain: Add image #106

0pdd opened this issue Mar 23, 2019 · 1 comment
Labels
good first issue Good for newcomers help wanted Extra attention is needed

Comments

@0pdd
Copy link

0pdd commented Mar 23, 2019

The puzzle 1-18867a8f from #1 has to be resolved:

https://github.com/codeforthailand/election-live/blob/dcfac822b1d15e8620ab591ff01527de4f46ac7e/src/components/MainLayout.js#L173-L173

The puzzle was created by Thai Pangsakulyanont on 23-Mar-19.

If you have any technical questions, don't ask me, submit new tickets instead. The task will be "done" when the problem is fixed and the text of the puzzle is removed from the source code. Here is more about PDD and about me.
0pdd referenced this issue Mar 23, 2019
@dtinth
Add curtain
dcfac82
@0pdd 0pdd mentioned this issue Mar 23, 2019
Open
@dtinth dtinth added the help wanted Extra attention is needed label Mar 23, 2019
@dtinth
Copy link
Contributor

dtinth commented Mar 23, 2019

Design:

image

  • Use this GIF:
    count_live

  • Logo already in source tree

@dtinth dtinth added the good first issue Good for newcomers label Mar 23, 2019
@whs whs mentioned this issue Mar 23, 2019
Merged
0pdd referenced this issue Mar 23, 2019
@dtinth
Merge pull request #128 from whs/issue-106
22c638c 
CountdownCurtain: Added logo and animated image
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue Good for newcomers help wanted Extra attention is needed
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@dtinth @0pdd