Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

No coverage uploaded for pull request base (main@57ac245) #144

Closed
thomasrockhu-codecov opened this issue Nov 9, 2023 Discussed in #143 · 8 comments
Closed

No coverage uploaded for pull request base (main@57ac245) #144

thomasrockhu-codecov opened this issue Nov 9, 2023 Discussed in #143 · 8 comments
Assignees

Comments

@thomasrockhu-codecov
Copy link
Contributor

Discussed in #143

Originally posted by SimFG November 9, 2023
pr: zilliztech/milvus-cdc#24
the coverage of base:
image

I've been looking for the reason for a long time, but I still haven't found it. Plz help help help

@covecod covecod bot moved this to Waiting for: Product Owner in GitHub Issues with 👀 Nov 9, 2023
@thomasrockhu-codecov thomasrockhu-codecov self-assigned this Nov 9, 2023
@thomasrockhu-codecov
Copy link
Contributor Author

@SimFG updated to use v3 here. Suggestion is to merge this in (so that coverage for a new base can be created) and see if the problem persists in future commits.

@SimFG
Copy link

SimFG commented Nov 9, 2023

@thomasrockhu-codecov thanks your reply. I try it

@thomasrockhu-codecov thomasrockhu-codecov moved this from Waiting for: Product Owner to Waiting for: Community in GitHub Issues with 👀 Nov 9, 2023
@SimFG
Copy link

SimFG commented Nov 9, 2023

@thomasrockhu-codecov I have used the v3 version, but this error still exists.
pr: zilliztech/milvus-cdc#25

@covecod covecod bot moved this from Waiting for: Community to Waiting for: Product Owner in GitHub Issues with 👀 Nov 9, 2023
@thomasrockhu-codecov
Copy link
Contributor Author

@SimFG can you check the CODECOV_TOKEN on zilliztech/milvus-cdc matches that repo's token and not the fork?

@SimFG
Copy link

SimFG commented Nov 9, 2023

image
@thomasrockhu-codecov I get the token in this page. It should be correct, and i update the CODECOV_TOKEN on zilliztech/milvus-cdc

@SimFG
Copy link

SimFG commented Nov 9, 2023

From the codecov page, I can see the coverage details and I feel the token should be correct
image

@thomasrockhu-codecov
Copy link
Contributor Author

@SimFG you will need to merge to master and open a new pR, but the new token should be accurate if you pulled from that settings page

@SimFG
Copy link

SimFG commented Nov 9, 2023

@thomasrockhu-codecov Thanks a lot !!! it works !!!
image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Waiting for: Product Owner
Development

No branches or pull requests

2 participants