You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
The metamorphic test uses MemFS.CrashClone in the dbRestartOp, but that isn't concurrent with an Open. Similarly, TestCrashOpenCrashAfterWALCreation crashes after the Open returns. We don't seem to have code coverage for a crash during Open.
We could add another operation to the metamorphic test that does the unclean restart like dbRestartOp but also starts a short-lived concurrent goroutine that calls CrashClone during the Open and uses that clone do a second Open. We would inject slowness into the FS for the first Open, so that it is slow enough that we capture some arbitrary intermediate state.
Hmm, I could have sworn we had a test that exhaustively tested vfs errors during certain operations. TestErrors does this for a small set of operations, but not for recovery. See the use of errorfs.OnIndex. Perhaps @jbowens knows of where such a test already exists.
The metamorphic test uses
MemFS.CrashClone
in thedbRestartOp
, but that isn't concurrent with an Open. Similarly,TestCrashOpenCrashAfterWALCreation
crashes after the Open returns. We don't seem to have code coverage for a crash during Open.We could add another operation to the metamorphic test that does the unclean restart like
dbRestartOp
but also starts a short-lived concurrent goroutine that callsCrashClone
during theOpen
and uses that clone do a secondOpen
. We would inject slowness into the FS for the first Open, so that it is slow enough that we capture some arbitrary intermediate state.Jira issue: PEBBLE-342
The text was updated successfully, but these errors were encountered: