Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

metamorphic: test crash during Open #4342

Open
sumeerbhola opened this issue Feb 14, 2025 · 1 comment
Open

metamorphic: test crash during Open #4342

sumeerbhola opened this issue Feb 14, 2025 · 1 comment

Comments

@sumeerbhola
Copy link
Collaborator

sumeerbhola commented Feb 14, 2025

The metamorphic test uses MemFS.CrashClone in the dbRestartOp, but that isn't concurrent with an Open. Similarly, TestCrashOpenCrashAfterWALCreation crashes after the Open returns. We don't seem to have code coverage for a crash during Open.

We could add another operation to the metamorphic test that does the unclean restart like dbRestartOp but also starts a short-lived concurrent goroutine that calls CrashClone during the Open and uses that clone do a second Open. We would inject slowness into the FS for the first Open, so that it is slow enough that we capture some arbitrary intermediate state.

Jira issue: PEBBLE-342

@petermattis
Copy link
Collaborator

Hmm, I could have sworn we had a test that exhaustively tested vfs errors during certain operations. TestErrors does this for a small set of operations, but not for recovery. See the use of errorfs.OnIndex. Perhaps @jbowens knows of where such a test already exists.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants